mm: a question about high-order check in __zone_watermark_ok()
commit 97a16fc82a7c5b0cfce95c05dfb9561e306ca1b1
(mm, page_alloc: only enforce watermarks for order-0 allocations) rewrite the high-order check in __zone_watermark_ok(), but I think it quietly fix a bug. Please see the following.
Before this patch, the high-order check is this:__zone_watermark_ok()
...
for (o = 0; o < order; o++) {
/* At the next order, this order's pages become unavailable */
free_pages -= z->free_area[o].nr_free << o;
/* Require fewer higher order pages to be free */
min >>= 1;
if (free_pages <= min)
return false;
}
...If we have cma memory, and we alloc a high-order movable page, then it's right.
But if we alloc a high-order unmovable page(e.g. alloc kernel stack in dup_task_struct()), and there are a lot of high-order cma pages, but little high-order unmovable pages, the it is still return *true*, but we will alloc *failed* finally, because we cannot fallback from migrate_unmovable to migrate_cma, right?
Also if we doing __alloc_pages_slowpath(), the compact will not work, because __zone_watermark_ok() always return true, and it lead to alloc a high-order unmovable page failed, then do direct reclaim.
Thanks,
Xishi Qiu
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
[+CC Joonsoo Kim]
Quoted 20 lines · Xishi Qiu
commit
97a16fc82a7c5b0cfce95c05dfb9561e306ca1b1
(mm,page_alloc: only enforce watermarks for order-0 allocations) rewrite the high-order check in__zone_watermark_ok(), but I think it quietly fix a bug. Please see the following.Before this patch, the high-order check is this:
__zone_watermark_ok()... for (o = 0; o < order; o++) { /* At the next order, this order's pages become unavailable */ free_pages -= z->free_area[o].nr_free << o; /* Require fewer higher order pages to be free */ min >>= 1; if (free_pages <= min) return false; } ...
Quoted 6 lines
If we have cma memory, and we alloc a high-order movable page, then it's right.
But if we alloc a high-order unmovable page(e.g. alloc kernel stack in
dup_task_struct()), and there are a lot of high-order cma pages, but little high-order unmovable pages, the it is still return *true*, but we will alloc *failed* finally, because we cannot fallback frommigrate_unmovabletomigrate_cma, right?
Yeah I think this limitation was known to CMA people.
Quoted 3 lines
Also if we doing
__alloc_pages_slowpath(), the compact will not work, because__zone_watermark_ok()always return true, and it lead to alloc a high-order unmovable page failed, then do direct reclaim.
I guess that can happen as well.
Quoted 3 lines
Thanks,
Xishi Qiu
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 20 lines · Xishi Qiu
commit
97a16fc82a7c5b0cfce95c05dfb9561e306ca1b1
(mm,page_alloc: only enforce watermarks for order-0 allocations) rewrite the high-order check in__zone_watermark_ok(), but I think it quietly fix a bug. Please see the following.Before this patch, the high-order check is this:
__zone_watermark_ok()... for (o = 0; o < order; o++) { /* At the next order, this order's pages become unavailable */ free_pages -= z->free_area[o].nr_free << o; /* Require fewer higher order pages to be free */ min >>= 1; if (free_pages <= min) return false; } ...
Quoted 6 lines
If we have cma memory, and we alloc a high-order movable page, then it's right.
But if we alloc a high-order unmovable page(e.g. alloc kernel stack in
dup_task_struct()), and there are a lot of high-order cma pages, but little high-order unmovable pages, the it is still return *true*, but we will alloc *failed* finally, because we cannot fallback frommigrate_unmovabletomigrate_cma, right?
AFAIR CMA wmark check was always tricky and the above commit has made the situation at least a bit more clear. Anyway IIRC
#ifdef CONFIG_CMA /* If allocation can't use CMA areas don't use free CMA pages */ if (!(alloc_flags & ALLOC_CMA)) free_cma = zone_page_state(z, NR_FREE_CMA_PAGES);
#endif
if (free_pages - free_cma <= min + z->lowmem_reserve[classzone_idx]) return false;
should reduce the prioblem because a lot of CMA pages should just get us below the wmark + reserve boundary.
Signature · 8 lines
Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 35 lines · Michal Hocko
Quoted 20 lines · Xishi Qiu
commit
97a16fc82a7c5b0cfce95c05dfb9561e306ca1b1
(mm,page_alloc: only enforce watermarks for order-0 allocations) rewrite the high-order check in__zone_watermark_ok(), but I think it quietly fix a bug. Please see the following.Before this patch, the high-order check is this:
__zone_watermark_ok()... for (o = 0; o < order; o++) { /* At the next order, this order's pages become unavailable */ free_pages -= z->free_area[o].nr_free << o; /* Require fewer higher order pages to be free */ min >>= 1; if (free_pages <= min) return false; } ...Quoted 6 lines
If we have cma memory, and we alloc a high-order movable page, then it's right.
But if we alloc a high-order unmovable page(e.g. alloc kernel stack in
dup_task_struct()), and there are a lot of high-order cma pages, but little high-order unmovable pages, the it is still return *true*, but we will alloc *failed* finally, because we cannot fallback frommigrate_unmovabletomigrate_cma, right?AFAIR CMA wmark check was always tricky and the above commit has made the situation at least a bit more clear. Anyway IIRC
#ifdef CONFIG_CMA /* If allocation can't use CMA areas don't use free CMA pages */ if (!(alloc_flags & ALLOC_CMA)) free_cma = zone_page_state(z, NR_FREE_CMA_PAGES);
Quoted 7 lines
#endif
if (free_pages - free_cma <= min + z->lowmem_reserve[classzone_idx]) return false;should reduce the prioblem because a lot of CMA pages should just get us below the wmark + reserve boundary.
Hi Michal,
If we have many high-order cma pages, and the left pages (unmovable/movable/reclaimable) are also enough, but they are fragment, then it will triger the problem. If we alloc a high-order unmovable page, water mark check return *true*, but we will alloc *failed*, right?
Thanks,
Xishi Qiu
Quoted 45 lines · Xishi Qiu
Quoted 35 lines · Michal Hocko
Quoted 20 lines · Xishi Qiu
commit
97a16fc82a7c5b0cfce95c05dfb9561e306ca1b1
(mm,page_alloc: only enforce watermarks for order-0 allocations) rewrite the high-order check in__zone_watermark_ok(), but I think it quietly fix a bug. Please see the following.Before this patch, the high-order check is this:
__zone_watermark_ok()... for (o = 0; o < order; o++) { /* At the next order, this order's pages become unavailable */ free_pages -= z->free_area[o].nr_free << o; /* Require fewer higher order pages to be free */ min >>= 1; if (free_pages <= min) return false; } ...Quoted 6 lines
If we have cma memory, and we alloc a high-order movable page, then it's right.
But if we alloc a high-order unmovable page(e.g. alloc kernel stack in
dup_task_struct()), and there are a lot of high-order cma pages, but little high-order unmovable pages, the it is still return *true*, but we will alloc *failed* finally, because we cannot fallback frommigrate_unmovabletomigrate_cma, right?AFAIR CMA wmark check was always tricky and the above commit has made the situation at least a bit more clear. Anyway IIRC
#ifdef CONFIG_CMA /* If allocation can't use CMA areas don't use free CMA pages */ if (!(alloc_flags & ALLOC_CMA)) free_cma = zone_page_state(z, NR_FREE_CMA_PAGES);Quoted 7 lines
#endif
if (free_pages - free_cma <= min + z->lowmem_reserve[classzone_idx]) return false;should reduce the prioblem because a lot of CMA pages should just get us below the wmark + reserve boundary.
Quoted 6 lines
Hi Michal,
If we have many high-order cma pages, and the left pages (unmovable/movable/reclaimable) are also enough, but they are fragment, then it will triger the problem. If we alloc a high-order unmovable page, water mark check return *true*, but we will alloc *failed*, right?
As Vlastimil has written. There were known issues with the wmark checks and high order requests.
Signature · 8 lines
Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 48 lines · Michal Hocko
Quoted 47 lines · Xishi Qiu
Quoted 35 lines · Michal Hocko
Quoted 20 lines · Xishi Qiu
commit
97a16fc82a7c5b0cfce95c05dfb9561e306ca1b1
(mm,page_alloc: only enforce watermarks for order-0 allocations) rewrite the high-order check in__zone_watermark_ok(), but I think it quietly fix a bug. Please see the following.Before this patch, the high-order check is this:
__zone_watermark_ok()... for (o = 0; o < order; o++) { /* At the next order, this order's pages become unavailable */ free_pages -= z->free_area[o].nr_free << o; /* Require fewer higher order pages to be free */ min >>= 1; if (free_pages <= min) return false; } ...Quoted 6 lines
If we have cma memory, and we alloc a high-order movable page, then it's right.
But if we alloc a high-order unmovable page(e.g. alloc kernel stack in
dup_task_struct()), and there are a lot of high-order cma pages, but little high-order unmovable pages, the it is still return *true*, but we will alloc *failed* finally, because we cannot fallback frommigrate_unmovabletomigrate_cma, right?AFAIR CMA wmark check was always tricky and the above commit has made the situation at least a bit more clear. Anyway IIRC
#ifdef CONFIG_CMA /* If allocation can't use CMA areas don't use free CMA pages */ if (!(alloc_flags & ALLOC_CMA)) free_cma = zone_page_state(z, NR_FREE_CMA_PAGES);Quoted 7 lines
#endif
if (free_pages - free_cma <= min + z->lowmem_reserve[classzone_idx]) return false;should reduce the prioblem because a lot of CMA pages should just get us below the wmark + reserve boundary.
Hi Michal,
Quoted 7 lines
Quoted 4 lines
If we have many high-order cma pages, and the left pages (unmovable/movable/reclaimable) are also enough, but they are fragment, then it will triger the problem. If we alloc a high-order unmovable page, water mark check return *true*, but we will alloc *failed*, right?
As Vlastimil has written. There were known issues with the wmark checks and high order requests.
Shall we backport to stable?
Thanks,
Xishi Qiu
Quoted 55 lines · Xishi Qiu
Quoted 53 lines · Michal Hocko
Quoted 51 lines · Xishi Qiu
Quoted 35 lines · Michal Hocko
Quoted 20 lines · Xishi Qiu
commit
97a16fc82a7c5b0cfce95c05dfb9561e306ca1b1
(mm,page_alloc: only enforce watermarks for order-0 allocations) rewrite the high-order check in__zone_watermark_ok(), but I think it quietly fix a bug. Please see the following.Before this patch, the high-order check is this:
__zone_watermark_ok()... for (o = 0; o < order; o++) { /* At the next order, this order's pages become unavailable */ free_pages -= z->free_area[o].nr_free << o; /* Require fewer higher order pages to be free */ min >>= 1; if (free_pages <= min) return false; } ...Quoted 6 lines
If we have cma memory, and we alloc a high-order movable page, then it's right.
But if we alloc a high-order unmovable page(e.g. alloc kernel stack in
dup_task_struct()), and there are a lot of high-order cma pages, but little high-order unmovable pages, the it is still return *true*, but we will alloc *failed* finally, because we cannot fallback frommigrate_unmovabletomigrate_cma, right?AFAIR CMA wmark check was always tricky and the above commit has made the situation at least a bit more clear. Anyway IIRC
#ifdef CONFIG_CMA /* If allocation can't use CMA areas don't use free CMA pages */ if (!(alloc_flags & ALLOC_CMA)) free_cma = zone_page_state(z, NR_FREE_CMA_PAGES);Quoted 7 lines
#endif
if (free_pages - free_cma <= min + z->lowmem_reserve[classzone_idx]) return false;should reduce the prioblem because a lot of CMA pages should just get us below the wmark + reserve boundary.
Hi Michal,
If we have many high-order cma pages, and the left pages (unmovable/movable/reclaimable) are also enough, but they are fragment, then it will triger the problem. If we alloc a high-order unmovable page, water mark check return *true*, but we will alloc *failed*, right?
Quoted 4 lines
Quoted 2 lines
As Vlastimil has written. There were known issues with the wmark checks and high order requests.
Shall we backport to stable?
I dunno, it was a part of a larger series with high atomic reserves and changes which sound a bit intrusive for the stable kernel. Considering that CMA was known to be problematic and there are still some issues left I do not think this is worth the trouble/risk.
Signature · 8 lines
Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 59 lines · Michal Hocko
Quoted 58 lines · Xishi Qiu
Quoted 55 lines · Michal Hocko
Quoted 45 lines · Xishi Qiu
Quoted 35 lines · Michal Hocko
Quoted 20 lines · Xishi Qiu
commit
97a16fc82a7c5b0cfce95c05dfb9561e306ca1b1
(mm,page_alloc: only enforce watermarks for order-0 allocations) rewrite the high-order check in__zone_watermark_ok(), but I think it quietly fix a bug. Please see the following.Before this patch, the high-order check is this:
__zone_watermark_ok()... for (o = 0; o < order; o++) { /* At the next order, this order's pages become unavailable */ free_pages -= z->free_area[o].nr_free << o; /* Require fewer higher order pages to be free */ min >>= 1; if (free_pages <= min) return false; } ...Quoted 6 lines
If we have cma memory, and we alloc a high-order movable page, then it's right.
But if we alloc a high-order unmovable page(e.g. alloc kernel stack in
dup_task_struct()), and there are a lot of high-order cma pages, but little high-order unmovable pages, the it is still return *true*, but we will alloc *failed* finally, because we cannot fallback frommigrate_unmovabletomigrate_cma, right?AFAIR CMA wmark check was always tricky and the above commit has made the situation at least a bit more clear. Anyway IIRC
#ifdef CONFIG_CMA /* If allocation can't use CMA areas don't use free CMA pages */ if (!(alloc_flags & ALLOC_CMA)) free_cma = zone_page_state(z, NR_FREE_CMA_PAGES);Quoted 7 lines
#endif
if (free_pages - free_cma <= min + z->lowmem_reserve[classzone_idx]) return false;should reduce the prioblem because a lot of CMA pages should just get us below the wmark + reserve boundary.
Quoted 6 lines
Hi Michal,
If we have many high-order cma pages, and the left pages (unmovable/movable/reclaimable) are also enough, but they are fragment, then it will triger the problem. If we alloc a high-order unmovable page, water mark check return *true*, but we will alloc *failed*, right?
As Vlastimil has written. There were known issues with the wmark checks and high order requests.
Quoted 6 lines
Quoted 1 line
Shall we backport to stable?
I dunno, it was a part of a larger series with high atomic reserves and changes which sound a bit intrusive for the stable kernel. Considering that CMA was known to be problematic and there are still some issues left I do not think this is worth the trouble/risk.
CMA problem is known one. I mentioned it on my ZONE_CMA series v1 but removed due to Mel's high atomic reserve series.
That series is rather large and has some problems so I think that it is not suitable for stable tree.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 67 lines · Joonsoo Kim
Quoted 59 lines · Michal Hocko
Quoted 58 lines · Xishi Qiu
Quoted 55 lines · Michal Hocko
Quoted 45 lines · Xishi Qiu
Quoted 35 lines · Michal Hocko
Quoted 20 lines · Xishi Qiu
commit
97a16fc82a7c5b0cfce95c05dfb9561e306ca1b1
(mm,page_alloc: only enforce watermarks for order-0 allocations) rewrite the high-order check in__zone_watermark_ok(), but I think it quietly fix a bug. Please see the following.Before this patch, the high-order check is this:
__zone_watermark_ok()... for (o = 0; o < order; o++) { /* At the next order, this order's pages become unavailable */ free_pages -= z->free_area[o].nr_free << o; /* Require fewer higher order pages to be free */ min >>= 1; if (free_pages <= min) return false; } ...Quoted 6 lines
If we have cma memory, and we alloc a high-order movable page, then it's right.
But if we alloc a high-order unmovable page(e.g. alloc kernel stack in
dup_task_struct()), and there are a lot of high-order cma pages, but little high-order unmovable pages, the it is still return *true*, but we will alloc *failed* finally, because we cannot fallback frommigrate_unmovabletomigrate_cma, right?AFAIR CMA wmark check was always tricky and the above commit has made the situation at least a bit more clear. Anyway IIRC
#ifdef CONFIG_CMA /* If allocation can't use CMA areas don't use free CMA pages */ if (!(alloc_flags & ALLOC_CMA)) free_cma = zone_page_state(z, NR_FREE_CMA_PAGES);Quoted 7 lines
#endif
if (free_pages - free_cma <= min + z->lowmem_reserve[classzone_idx]) return false;should reduce the prioblem because a lot of CMA pages should just get us below the wmark + reserve boundary.
Quoted 6 lines
Hi Michal,
If we have many high-order cma pages, and the left pages (unmovable/movable/reclaimable) are also enough, but they are fragment, then it will triger the problem. If we alloc a high-order unmovable page, water mark check return *true*, but we will alloc *failed*, right?
As Vlastimil has written. There were known issues with the wmark checks and high order requests.
Quoted 6 lines
Quoted 1 line
Shall we backport to stable?
I dunno, it was a part of a larger series with high atomic reserves and changes which sound a bit intrusive for the stable kernel. Considering that CMA was known to be problematic and there are still some issues left I do not think this is worth the trouble/risk.
Quoted 8 lines
CMA problem is known one. I mentioned it on my
ZONE_CMAseries v1 but removed due to Mel's high atomic reserve series.That series is rather large and has some problems so I think that it is not suitable for stable tree.
Thanks.
OK, I know, thank you very much.
Thanks,
Xishi Qiu
Quoted 2 lines
.