Skip to contentSkip to conversation

staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.

PATCH In review Matias Mucciolo 2 participants 5 messages Sep 26, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.

- Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared.

---
 drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wilc1000/wilc_debugfs.c +1 -1
index b052628..802bb1d 100644
@@ -29,7 +29,7 @@ static struct dentry *wilc_dir;
 #define ERR             BIT(3)
 
 #define DBG_LEVEL_ALL	(DEBUG | INFO | WRN | ERR)
-atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
+static atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
 EXPORT_SYMBOL_GPL(WILC_DEBUG_LEVEL);
 
 /*
Signature · 1 line
2.1.4
#1 lore raw
Quoted 2 lines · Matias Mucciolo

- Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared.

I don't think that was the full warning, as that does not make much sense to me, does it to you?

thanks,

greg k-h

#2 lore raw

hi

sorry...this is the full warning:

drivers/staging/wilc1000/wilc_debugfs.c:32:10: warning: symbol 'WILC_DEBUG_LEVEL' was not declared. Should it be static?

Signature · 5 lines
Matias Mucciolo

Area de Infraestructura.
Piedras 737 C.A.B.A 
SUTEBA 
Quoted 10 lines · On Monday 26 September 2016 17:37:33 Greg Kroah-Hartman wrote:
Quoted 2 lines · Matias Mucciolo

- Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared.

I don't think that was the full warning, as that does not make much sense to me, does it to you?

thanks,

greg k-h

#3 lore raw
Quoted 6 lines · Matias Mucciolo

hi

sorry...this is the full warning:

drivers/staging/wilc1000/wilc_debugfs.c:32:10: warning: symbol 'WILC_DEBUG_LEVEL' was not declared. Should it be static?

the "should it be static" is the key here, right? Care to fix this up and resend it?

thanks,

greg k-h

#4 lore raw

PATCH 1/1 staging: wilc1000: fix sparse warning: symbol was not declared. Should it be static?

- Fixed a sparse warning:
wilc_debugfs.c:32:10: warning: symbol 'WILC_DEBUG_LEVEL' was not declared. Should it be static?

---
 drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wilc1000/wilc_debugfs.c +1 -1
index b052628..802bb1d 100644
@@ -29,7 +29,7 @@ static struct dentry *wilc_dir;
 #define ERR             BIT(3)
 
 #define DBG_LEVEL_ALL	(DEBUG | INFO | WRN | ERR)
-atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
+static atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
 EXPORT_SYMBOL_GPL(WILC_DEBUG_LEVEL);
 
 /*
Signature · 1 line
2.1.4