staging: sm750fb: Refactor camelCase macro
Subsystems (2)
PATCH 1/1 staging: sm750fb: Refactor camelCase macro
This patch refactors a camelcase macro roundedDiv to rounded_div. Error found by checkpatch.
--- drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/sm750fb/ddk750_chip.c +3 -3
@@ -7,7 +7,7 @@#include "ddk750_power.h" /* n / d + 1 / 2 = (2n + d) / 2d */ -#define roundedDiv (num, denom) ((2 * (num) + (denom)) / (2 * (denom))) +#define rounded_div (num, denom) ((2 * (num) + (denom)) / (2 * (denom)))#define MHz (x) ((x) * 1000000)logical_chip_type_t getChipType (void )
@@ -102,7 +102,7 @@ static void setMemoryClock(unsigned int frequency) frequency =MHz (336 );/* Calculate the divisor */ - divisor =roundedDiv (get_mxclk_freq (), frequency); + divisor =rounded_div (get_mxclk_freq (), frequency);/* Set the corresponding divisor in the register. */ reg =PEEK32 (CURRENT_GATE ) & ~CURRENT_GATE_M2XCLK_MASK ;
@@ -152,7 +152,7 @@ static void setMasterClock(unsigned int frequency) frequency =MHz (190 );/* Calculate the divisor */ - divisor =roundedDiv (get_mxclk_freq (), frequency); + divisor =rounded_div (get_mxclk_freq (), frequency);/* Set the corresponding divisor in the register. */ reg =PEEK32 (CURRENT_GATE ) & ~CURRENT_GATE_MCLK_MASK ;
Signature · 1 line
2.1.4
Quoted 1 line · Elizabeth Ferdman
This patch refactors a camelcase macro roundedDiv to
rounded_div. Error found by checkpatch.
Refactors seems like kind of a big word for just a renaming. Refactoring would suggest a larger scale reorganization.
julia
Quoted 47 lines
Signed-off-by Elizabeth Ferdman <[email protected]>--- drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/sm750fb/ddk750_chip.c +3
-4@@ -7,7 +7,7 @@#include "ddk750_power.h" /* n / d + 1 / 2 = (2n + d) / 2d */ -#define roundedDiv (num, denom) ((2 * (num) + (denom)) / (2 * (denom))) +#define rounded_div (num, denom) ((2 * (num) + (denom)) / (2 * (denom)))#define MHz (x) ((x) * 1000000)logical_chip_type_t getChipType (void )@@ -102,7 +102,7 @@ static void setMemoryClock(unsigned int frequency) frequency =MHz (336 );/* Calculate the divisor */ - divisor =roundedDiv (get_mxclk_freq (), frequency); + divisor =rounded_div (get_mxclk_freq (), frequency);/* Set the corresponding divisor in the register. */ reg =PEEK32 (CURRENT_GATE ) & ~CURRENT_GATE_M2XCLK_MASK ;@@ -152,7 +152,7 @@ static void setMasterClock(unsigned int frequency) frequency =MHz (190 );/* Calculate the divisor */ - divisor =roundedDiv (get_mxclk_freq (), frequency); + divisor =rounded_div (get_mxclk_freq (), frequency);/* Set the corresponding divisor in the register. */ reg =PEEK32 (CURRENT_GATE ) & ~CURRENT_GATE_MCLK_MASK ; --2.1.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160926220150.GA2273%40localhost.
For more options, visit https://groups.google.com/d/optout.