U-Boot DFU test and Ctrl+C
Hey guys,
As I use the DFU tests more and more, I keep hitting what I'm pretty sure is a false failure in the tests. Sometimes the tests fail at:
Quoted 1 line
u_boot_console.wait_for('Ctrl+C to exit ...')and the last bit of the console log is:
Starting download: [#################################################################] finished! unable to read DFU status
#File System is consistent
file found, deleting
update journal finished
File System is consistent
update journal finished
65 bytes written in 12380 ms (0 Bytes/s)
=>
So perhaps we should make the test look for the prompt itself rather than 'Ctrl+C' ? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160927/d8c3a238/attachment.sig>
Quoted 17 lines · Tom Rini
Hey guys,
As I use the DFU tests more and more, I keep hitting what I'm pretty sure is a false failure in the tests. Sometimes the tests fail at:
Quoted 1 line
u_boot_console.wait_for('Ctrl+C to exit ...')and the last bit of the console log is:
Starting download: [#################################################################] finished! unable to read DFU status
#File System is consistent
file found, deleting
update journal finished
File System is consistent
update journal finished
65 bytes written in 12380 ms (0 Bytes/s)
=>
Quoted 2 lines
So perhaps we should make the test look for the prompt itself rather than 'Ctrl+C' ? Thanks!
FWIW, I haven't seen this issue at all.
This looks like a bug in the DFU code to me; from the log you gave it seems like the dfu shell command is exiting back to the shell prompt all by itself. It shouldn't do that, but should rather wait for the user to press Ctrl-C. The only exception would be that the host tool has some options to trigger a "reset" on the target. The test/py code shouldn't be using that option though, and IIRC U-Boot attempts a CPU/board reset in response to that command rather than simply dropping back to the shell prompt.
Hi Tom,
Quoted 17 lines
Hey guys,
As I use the DFU tests more and more, I keep hitting what I'm pretty sure is a false failure in the tests. Sometimes the tests fail at:
Quoted 1 line
u_boot_console.wait_for('Ctrl+C to exit ...')and the last bit of the console log is:
Starting download:
[#################################################################] finished! unable to read DFU status #File System is consistent file found, deleting
update journal finished
File System is consistent
update journal finished
65 bytes written in 12380 ms (0 Bytes/s)
=>
Quoted 2 lines
So perhaps we should make the test look for the prompt itself rather than 'Ctrl+C' ? Thanks!
As fair as I remember, dfu-util provides and u-boot's dfu supports -e switch behavior. This switch causes the dfu u-boot command to go directly to u-boot prompt.
Tom, I suppose that this is what you would need.
Just add -e to your host's dfu-util command.
Quoted 1 line
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
Quoted 22 lines · Lukasz Majewski
Hi Tom,
Quoted 17 lines
Hey guys,
As I use the DFU tests more and more, I keep hitting what I'm pretty sure is a false failure in the tests. Sometimes the tests fail at:
Quoted 1 line
u_boot_console.wait_for('Ctrl+C to exit ...')and the last bit of the console log is:
Starting download:
[#################################################################] finished! unable to read DFU status #File System is consistent file found, deleting
update journal finished
File System is consistent
update journal finished
65 bytes written in 12380 ms (0 Bytes/s)
=>Quoted 2 lines
So perhaps we should make the test look for the prompt itself rather than 'Ctrl+C' ? Thanks!
Quoted 6 lines
As fair as I remember, dfu-util provides and u-boot's dfu supports -e switch behavior. This switch causes the dfu u-boot command to go directly to u-boot prompt.
Tom, I suppose that this is what you would need.
Just add -e to your host's dfu-util command.
Using -e is the opposite of what Tom wants. The test/py script expects the dfu command to continue running after an upload/download, since that's the default behaviour.
Quoted 27 lines · Stephen Warren
Quoted 26 lines · Lukasz Majewski
Hi Tom,
Quoted 17 lines
Hey guys,
As I use the DFU tests more and more, I keep hitting what I'm pretty sure is a false failure in the tests. Sometimes the tests fail at:
Quoted 1 line
u_boot_console.wait_for('Ctrl+C to exit ...')and the last bit of the console log is:
Starting download:
[#################################################################] finished! unable to read DFU status #File System is consistent file found, deleting
update journal finished
File System is consistent
update journal finished
65 bytes written in 12380 ms (0 Bytes/s)
=>Quoted 2 lines
So perhaps we should make the test look for the prompt itself rather than 'Ctrl+C' ? Thanks!
As fair as I remember, dfu-util provides and u-boot's dfu supports -e switch behavior. This switch causes the dfu u-boot command to go directly to u-boot prompt.
Quoted 6 lines
Quoted 2 lines
Tom, I suppose that this is what you would need.
Just add -e to your host's dfu-util command.Using -e is the opposite of what Tom wants. The test/py script expects the dfu command to continue running after an upload/download, since that's the default behaviour.
Right. It sounds like DWC3 might have an intermittent issue I need to find some time to try and debug, or talk someone else into debugging :)
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160930/1d97aa9d/attachment.sig>