Skip to contentSkip to conversation

Add DRA72 Rev C support

PATCH New Mugunthan V N 2 participants 7 messages Sep 27, 2016 – Oct 8, 2016 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

cover Add DRA72 Rev C support

Add support for dra72 Rev C evm. The patch has been tested on DRA72 EVM Rev C, DRA72 EVM Rev B and DRA74 EVM Rev G, logs [1]. Also pushed a branch for testing [2].

[1] - http://pastebin.ubuntu.com/23239294/
[2] - git://git.ti.com/~mugunthanvnm/ti-u-boot/mugunth-ti-u-boot.git dra72-revC

Mugunthan V N (2):
ARM: dts: dra72: add rev C evm support
board: ti: dra7xx: complex definitions should be protected with
parentheses

 arch/arm/dts/Makefile              |   3 +-
 arch/arm/dts/dra72-evm-common.dtsi | 513 ++++++++++++++++++++++++++++
 arch/arm/dts/dra72-evm-revc.dts    |  70 ++++
 arch/arm/dts/dra72-evm.dts         | 664 +------------------------------------
 board/ti/dra7xx/evm.c              |  24 +-
 configs/dra7xx_evm_defconfig       |   2 +-
 6 files changed, 605 insertions(+), 671 deletions(-)
 create mode 100644 arch/arm/dts/dra72-evm-common.dtsi
 create mode 100644 arch/arm/dts/dra72-evm-revc.dts
Signature · 1 line
2.10.0.372.g6fe1b14
#1 lore raw

PATCH 1/2 ARM: dts: dra72: add rev C evm support

Add DTS support for dra72 evm Rev C which has the following changes
* Two ethernet ports now instead of the single one in rev B.
* DP83867 ethernet phy instead of DP838865.

---
 arch/arm/dts/Makefile              |   3 +-
 arch/arm/dts/dra72-evm-common.dtsi | 513 ++++++++++++++++++++++++++++
 arch/arm/dts/dra72-evm-revc.dts    |  70 ++++
 arch/arm/dts/dra72-evm.dts         | 664 +------------------------------------
 board/ti/dra7xx/evm.c              |  16 +-
 configs/dra7xx_evm_defconfig       |   2 +-
 6 files changed, 601 insertions(+), 667 deletions(-)
 create mode 100644 arch/arm/dts/dra72-evm-common.dtsi
 create mode 100644 arch/arm/dts/dra72-evm-revc.dts
arch/arm/dts/Makefile +2 -1
index e89b6e80..472ca1a 100644
@@ -131,7 +131,8 @@ dtb-$(CONFIG_ARCH_SOCFPGA) +=				\
 	socfpga_cyclone5_sr1500.dtb			\
 	socfpga_cyclone5_vining_fpga.dtb
 
-dtb-$(CONFIG_TARGET_DRA7XX_EVM) += dra72-evm.dtb dra7-evm.dtb
+dtb-$(CONFIG_TARGET_DRA7XX_EVM) += dra72-evm.dtb dra7-evm.dtb	\
+	dra72-evm-revc.dtb
 dtb-$(CONFIG_TARGET_AM57XX_EVM) += am57xx-beagle-x15.dtb \
 	am572x-idk.dtb
 dtb-$(CONFIG_TARGET_STV0991) += stv0991.dtb
arch/arm/dts/dra72-evm-common.dtsi new file +513 -0

513 lines not on this page · raw message

arch/arm/dts/dra72-evm-revc.dts new file +70 -0

70 lines not on this page · raw message

arch/arm/dts/dra72-evm.dts +4 -660

693 lines not on this page · raw message

board/ti/dra7xx/evm.c +11 -5
index 99e8254..be9af76 100644
@@ -828,12 +828,18 @@ int ft_board_setup(void *blob, bd_t *bd)
 #ifdef CONFIG_SPL_LOAD_FIT
 int board_fit_config_name_match(const char *name)
 {
-	if (is_dra72x() && !strcmp(name, "dra72-evm"))
-		return 0;
-	else if (!is_dra72x() && !strcmp(name, "dra7-evm"))
+	if (is_dra72x()) {
+		if (board_is_dra72x_revc_or_later()) {
+			if (!strcmp(name, "dra72-evm-revc"))
+				return 0;
+		} else if (!strcmp(name, "dra72-evm")) {
+			return 0;
+		}
+	} else if (!is_dra72x() && !strcmp(name, "dra7-evm")) {
 		return 0;
-	else
-		return -1;
+	}
+
+	return -1;
 }
 #endif
 
configs/dra7xx_evm_defconfig +1 -1
index 64df490..3a80e8d 100644
@@ -36,7 +36,7 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_CONTROL=y
-CONFIG_OF_LIST="dra7-evm dra72-evm"
+CONFIG_OF_LIST="dra7-evm dra72-evm dra72-evm-revc"
 CONFIG_DM=y
 CONFIG_DM_GPIO=y
 CONFIG_PCF8575_GPIO=y
Signature · 1 line
2.10.0.372.g6fe1b14
#2 lore raw

PATCH 1/2 ARM: dts: dra72: add rev C evm support

Quoted 7 lines · Mugunthan V N

Add DTS support for dra72 evm Rev C which has the following changes
* Two ethernet ports now instead of the single one in rev B.
* DP83867 ethernet phy instead of DP838865.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160927/19967c60/attachment.sig>
#3 lore raw

PATCH 1/2 ARM: dts: dra72: add rev C evm support

In reply to Mugunthan V N
Quoted 8 lines · Mugunthan V N

Add DTS support for dra72 evm Rev C which has the following changes
* Two ethernet ports now instead of the single one in rev B.
* DP83867 ethernet phy instead of DP838865.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161008/0a03ee0d/attachment.sig>
#4 lore raw

PATCH 2/2 board: ti: dra7xx: complex definitions should be protected with parentheses

In reply to Mugunthan V N

As a standard practice complex definitions should be protected with parentheses, as it might fail when used in a complex if statements.

---
 board/ti/dra7xx/evm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
board/ti/dra7xx/evm.c +4 -4
index be9af76..af4bc4e 100644
@@ -36,10 +36,10 @@
 
 #define board_is_dra74x_evm()		board_ti_is("5777xCPU")
 #define board_is_dra72x_evm()		board_ti_is("DRA72x-T")
-#define board_is_dra74x_revh_or_later() board_is_dra74x_evm() &&	\
-				(strncmp("H", board_ti_get_rev(), 1) <= 0)
-#define board_is_dra72x_revc_or_later() board_is_dra72x_evm() &&	\
-				(strncmp("C", board_ti_get_rev(), 1) <= 0)
+#define board_is_dra74x_revh_or_later() (board_is_dra74x_evm() &&	\
+				(strncmp("H", board_ti_get_rev(), 1) <= 0))
+#define board_is_dra72x_revc_or_later() (board_is_dra72x_evm() &&	\
+				(strncmp("C", board_ti_get_rev(), 1) <= 0))
 #define board_ti_get_emif_size()	board_ti_get_emif1_size() +	\
 					board_ti_get_emif2_size()
 
Signature · 1 line
2.10.0.372.g6fe1b14
#5 lore raw

PATCH 2/2 board: ti: dra7xx: complex definitions should be protected with parentheses

Quoted 5 lines · Mugunthan V N

As a standard practice complex definitions should be protected with parentheses, as it might fail when used in a complex if statements.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160927/3571993d/attachment.sig>
#6 lore raw

PATCH 2/2 board: ti: dra7xx: complex definitions should be protected with parentheses

In reply to Mugunthan V N
Quoted 6 lines · Mugunthan V N

As a standard practice complex definitions should be protected with parentheses, as it might fail when used in a complex if statements.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161008/8b633823/attachment.sig>