staging: fbtft: Fix checkpatch warning
Subsystems (2)
PATCH 1/1 staging: fbtft: Fix checkpatch warning
Improve code readability.
Signed-off-by Carlos Palminha <[email protected]>
---
Changes v1->v2:
- Added signed-off-by and comment.
drivers/staging/fbtft/fbtft_device.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/fbtft/fbtft_device.c +2 -4
@@ -841,7 +841,6 @@ static struct fbtft_device_display displays[] = { } } }, { - .name = "piscreen", .spi = &(struct spi_board_info ) { .modalias = "fb_ili9486",
@@ -1418,14 +1417,14 @@ static int __init fbtft_device_init(void)/* parse module parameter: gpios */ while ((p_gpio =strsep (&gpios,"," ))) { -if (strchr (p_gpio,':' ) ==NULL ) { +if (!strchr (p_gpio,':' )) {pr_err ("error: missing ':' in gpios parameter: %s\n" , p_gpio);return -EINVAL ; } p_num = p_gpio; p_name =strsep (&p_num,":" ); -if (p_name ==NULL || p_num ==NULL ) { +if (!p_name || !p_num) {pr_err ("something bad happened parsing gpios parameter: %s\n" , p_gpio);return -EINVAL ;
@@ -1586,7 +1585,6 @@ static void __exit fbtft_device_exit(void)if (p_device)platform_device_unregister (p_device); - }arch_initcall (fbtft_device_init);
Signature · 1 line
2.9.3
Greg KH
maintainerQuoted 1 line · Carlos Palminha
Improve code readability.
You are doing multiple things in the same patch, and you don't really tell us what you are doing, or why you are doing it...
Please take a step back, relax, and wait a day before resending a patch series for these issues.
thanks,
greg k-h