staging: iio: gyro: add comment to mutex
Subsystems (4)
PATCH 1/1 staging: iio: gyro: add comment to mutex
Fix the checkpatch.pl issues:
CHECK: struct mutes definition without comment
--- drivers/staging/iio/gyro/adis16060_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/gyro/adis16060_core.c +1 -1
@@ -33,7 +33,7 @@struct adis16060_state {struct spi_device *us_w;struct spi_device *us_r; -struct mutex buf_lock; +struct mutex buf_lock;/* protect tx and rx */ u8 buf[3 ]____cacheline_aligned ; };
Signature · 1 line
1.9.1
Quoted 2 lines · Anchal Jain
Fix the checkpatch.pl issues:
CHECK: struct mutes definition without comment
^^spelling
Quoted 2 lines
Signed-off-by Anchal Jain <[email protected]>
Hi Anchal, I'm going to be picky on these, because I sense you are getting on a roll here and we should establish a pattern.
- see spelling above.
- include driver name in IIO commit paths.
Caveat: if the subdir and driver names get so crazy long that you can't fit a good commit message, then leave off the subdir.
- tab out the comment instead of space.
- At first I thought tx and rx were kind of terse, but when I scroll up and see the comment above, it all makes sense.
- I might have said 'protect transfer buffers'
Please update with the minor cleanups and resend to the wider 'CC list as suggested in your previous patch.
alisons
Quoted 26 lines
--- drivers/staging/iio/gyro/adis16060_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/iio/gyro/adis16060_core.c +1
-1@@ -33,7 +33,7 @@struct adis16060_state {struct spi_device *us_w;struct spi_device *us_r; -struct mutex buf_lock; +struct mutex buf_lock;/* protect tx and rx */ u8 buf[3 ]____cacheline_aligned ; };Signature · 8 lines
1.9.1 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160928170708.GA6196%40life-desktop. For more options, visit https://groups.google.com/d/optout.
Quoted 10 lines · Alison Schofield
Quoted 2 lines · Anchal Jain
Fix the checkpatch.pl issues:
CHECK: struct mutes definition without comment^^spelling
Quoted 2 lines
Signed-off-by Anchal Jain <[email protected]>Hi Anchal, I'm going to be picky on these, because I sense you are getting on a roll here and we should establish a pattern.
Quoted 7 lines
- see spelling above.
- include driver name in IIO commit paths.
Caveat: if the subdir and driver names get so crazy long that you can't fit a good commit message, then leave off the subdir.
- tab out the comment instead of space.
- At first I thought tx and rx were kind of terse, but when I scroll up and see the comment above, it all makes sense.
tx and rx seem well understood. A bit more concrete than transfer buffers.
julia
Quoted 41 lines
- I might have said 'protect transfer buffers'
Please update with the minor cleanups and resend to the wider 'CC list as suggested in your previous patch.
alisons
Quoted 20 lines
--- drivers/staging/iio/gyro/adis16060_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/iio/gyro/adis16060_core.c +1
-2@@ -33,7 +33,7 @@struct adis16060_state {struct spi_device *us_w;struct spi_device *us_r; -struct mutex buf_lock; +struct mutex buf_lock;/* protect tx and rx */ u8 buf[3 ]____cacheline_aligned ; }; --1.9.1
Quoted 6 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160928170708.GA6196%40life-desktop.
For more options, visit https://groups.google.com/d/optout.--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160928175504.GA10225%40d830.WORKGROUP.
For more options, visit https://groups.google.com/d/optout.