staging: sm750fb: replace local macro w builtin fn

PATCH Superseded Elizabeth Ferdman 2 participants 2 messages Sep 29, 2016 – Oct 2, 2016

Subsystems (2)

Staging Staging - silicon motion SM750 frame buffer driver

lore

Share & tools

lore

Elizabeth Ferdman

author

2016-09-29 20:34 UTC #0 lore raw

PATCH 1/1 staging: sm750fb: replace local macro w builtin fn

Drop a local macro definition and replace its uses with a standard macro function from linux/kernel.h.

Signed-off-by Elizabeth Ferdman <[email protected]>

---
 drivers/staging/sm750fb/ddk750_chip.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

drivers/staging/sm750fb/ddk750_chip.c +2 -4

index 3a0afe1..839d673 100644
@@ -6,8 +6,6 @@
 #include "ddk750_chip.h"
 #include "ddk750_power.h"
 
-/* n / d + 1 / 2 = (2n + d) / 2d */
-#define roundedDiv(num, denom)	((2 * (num) + (denom)) / (2 * (denom)))
 #define MHz(x) ((x) * 1000000)
 
 logical_chip_type_t sm750_get_chip_type(void)

@@ -102,7 +100,7 @@ static void setMemoryClock(unsigned int frequency)
 			frequency = MHz(336);
 
 		/* Calculate the divisor */
-		divisor = roundedDiv(get_mxclk_freq(), frequency);
+		divisor = DIV_ROUND_CLOSEST(get_mxclk_freq(), frequency);
 
 		/* Set the corresponding divisor in the register. */
 		reg = PEEK32(CURRENT_GATE) & ~CURRENT_GATE_M2XCLK_MASK;

@@ -152,7 +150,7 @@ static void setMasterClock(unsigned int frequency)
 			frequency = MHz(190);
 
 		/* Calculate the divisor */
-		divisor = roundedDiv(get_mxclk_freq(), frequency);
+		divisor = DIV_ROUND_CLOSEST(get_mxclk_freq(), frequency);
 
 		/* Set the corresponding divisor in the register. */
 		reg = PEEK32(CURRENT_GATE) & ~CURRENT_GATE_MCLK_MASK;

Signature · 1 line

2.1.4

Greg KH

maintainer

2016-10-02 14:50 UTC #1 lore raw

Quoted 2 lines · Elizabeth Ferdman

Drop a local macro definition and replace its uses with a standard macro function from linux/kernel.h.

What is the "w" in the subject line?

And put the function name you are using in the subject as well, to show that this is using DIV_ROUND_CLOSEST. It needs to be somewhere at the very least...

thanks,

greg k-h