Skip to contentSkip to conversation

drm/amdgpu: enable powerplay unconditionally

PATCH In review Arnd Bergmann 2 participants 2 messages Sep 30, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: enable powerplay unconditionally

Using the newly exported amd_set_clockgating_by_smu function in the main amdgpu driver means that we can no longer build the driver without also enabling the powerplay component, otherwise we get this link error:

ERROR: "amd_set_clockgating_by_smu" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

The easiest way to avoid this error is to always enable the Kconfig symbol when the amdgpu driver is enabled.

Fixes a8ca34136453 ("drm/amdgpu: set gfx clock gating for tonga/polaris.")
Fixes 1bb08f91b0f6 ("drm/amdgpu: set system clock gating for tonga/polaris.")

---
It's quite likely that there is a better way to do this, as the separation of the drivers is intentional. If my patch isn't acceptable, please come up with a different solution.

---
 drivers/gpu/drm/amd/powerplay/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/Kconfig +1 -3
index af380335b425..6d4f155a0453 100644
@@ -1,6 +1,4 @@
 config DRM_AMD_POWERPLAY
-	bool  "Enable AMD powerplay component"
-	depends on DRM_AMDGPU
-	default n
+	def_bool DRM_AMDGPU
 	help
 	  select this option will enable AMD powerplay component.
Signature · 1 line
2.9.0
#1 lore raw
Quoted 21 lines

-----Original Message-----
From: Arnd Bergmann [mailto:[email protected]]
Sent: Friday, September 30, 2016 12:21 PM
To: Deucher, Alexander; Koenig, Christian
Cc: Arnd Bergmann; David Airlie; Zhou, Jammy; Zhu, Rex; dri- [email protected]; [email protected]
Subject: [PATCH] drm/amdgpu: enable powerplay unconditionally

Using the newly exported amd_set_clockgating_by_smu function in the main amdgpu driver
means that we can no longer build the driver without also enabling the powerplay
component, otherwise we get this link error:

ERROR: "amd_set_clockgating_by_smu"
[drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

The easiest way to avoid this error is to always enable the Kconfig symbol when
the amdgpu driver is enabled.

Quoted 8 lines
Fixes a8ca34136453 ("drm/amdgpu: set gfx clock gating for tonga/polaris.")
Fixes 1bb08f91b0f6 ("drm/amdgpu: set system clock gating for

tonga/polaris.")

---
It's quite likely that there is a better way to do this, as the separation of the drivers is intentional. If my patch isn't acceptable, please come up with a different solution.

I've already removed the kconfig symbol altogether:
https://lists.freedesktop.org/archives/dri-devel/2016-September/119647.html

Alex

Quoted 18 lines
---
 drivers/gpu/drm/amd/powerplay/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/Kconfig +1 -4
index af380335b425..6d4f155a0453 100644
@@ -1,6 +1,4 @@
 config DRM_AMD_POWERPLAY
-	bool  "Enable AMD powerplay component"
-	depends on DRM_AMDGPU
-	default n
+	def_bool DRM_AMDGPU
 	help
 	  select this option will enable AMD powerplay component.
--
Quoted 1 line

2.9.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel