Skip to contentSkip to conversation

bus: qcom-ebi2: depend on HAS_IOMEM

PATCH New Linus Walleij 4 participants 4 messages Oct 2, 2016 – Oct 4, 2016 Arm Qualcomm mailing list

lore
Share & tools
lore

Linus Walleij

author
#0 lore raw

PATCH 1/1 bus: qcom-ebi2: depend on HAS_IOMEM

After being asked to not depend on ARCH_QCOM* or similar, unsurprisingly compilation fails on UM as it has no I/O memory:

drivers/built-in.o: In function `qcom_ebi2_probe':

Quoted 1 line
Quoted 1 line

drivers/bus/qcom-ebi2.c:333: undefined reference to

`devm_ioremap_resource'

Fix this by letting the Kconfig atleast depend on HAS_IOMEM.

Reported-by kbuild test robot <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Andy Gross <[email protected]>
Cc linux-arm-msm at vger.kernel.org
Signed-off-by Linus Walleij <[email protected]>

---
ARM SoC maintainers: please apply this directly on the offending branch, or line it up for v4.9 fixes.

---
 drivers/bus/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/bus/Kconfig +1 -0
index 5a2d47c71525..7010dcac9328 100644
@@ -110,6 +110,7 @@ config OMAP_OCP2SCP
 
 config QCOM_EBI2
 	bool "Qualcomm External Bus Interface 2 (EBI2)"
+	depends on HAS_IOMEM
 	help
 	  Say y here to enable support for the Qualcomm External Bus
 	  Interface 2, which can be used to connect things like NAND Flash,
Signature · 1 line
2.7.4
Applied
#1 lore raw

PATCH 1/1 bus: qcom-ebi2: depend on HAS_IOMEM

Quoted 10 lines · Linus Walleij

After being asked to not depend on ARCH_QCOM* or similar, unsurprisingly compilation fails on UM as it has no I/O memory:

drivers/built-in.o: In function `qcom_ebi2_probe':

Quoted 1 line
Quoted 1 line

drivers/bus/qcom-ebi2.c:333: undefined reference to

`devm_ioremap_resource'

Fix this by letting the Kconfig atleast depend on HAS_IOMEM.

Quoted 8 lines
Reported-by kbuild test robot <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Andy Gross <[email protected]>
Cc linux-arm-msm at vger.kernel.org
Signed-off-by Linus Walleij <[email protected]>

---
ARM SoC maintainers: please apply this directly on the offending branch, or line it up for v4.9 fixes.

Applied to next/drivers. A Fixes: tag could have been nice, but it was easy to find where the offender was.

-Olof

#2 lore raw

PATCH 1/1 bus: qcom-ebi2: depend on HAS_IOMEM

In reply to Linus Walleij
Quoted 3 lines · Linus Walleij

After being asked to not depend on ARCH_QCOM* or similar, unsurprisingly compilation fails on UM as it has no I/O memory:

We could have depends on ARCH_QCOM || COMPILE_TEST and then life is good. The HAS_IOMEM would of course stick around for compile testing.

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
#3 lore raw

PATCH 1/1 bus: qcom-ebi2: depend on HAS_IOMEM

Quoted 7 lines · CEST Stephen Boyd
Quoted 3 lines · Linus Walleij

After being asked to not depend on ARCH_QCOM* or similar, unsurprisingly compilation fails on UM as it has no I/O memory:

We could have depends on ARCH_QCOM || COMPILE_TEST and then life is good. The HAS_IOMEM would of course stick around for compile testing.

Agreed, that would be nice also since most x86 don't want to see the Kconfig option unless they set COMPILE_TEST.

Note that COMPILE_TEST now depends on !UML, so we don't have to worry about that any more.

Arnd