sandbox, x86: select DM_KEYBOARD instead of default y entry
Subsystems (2)
PATCH 1/2 sandbox, x86: select DM_KEYBOARD instead of default y entry
Once we migrate to DM-based drivers, we cannot go back to legacy ones, i.e. config options like DM_* are not user-configurable.
Make SANDBOX and X86 select DM_KEYBOARD like other platforms do.
---
arch/Kconfig | 2 ++ arch/sandbox/Kconfig | 3 --- arch/x86/Kconfig | 3 --- 3 files changed, 2 insertions(+), 6 deletions(-)
arch/Kconfig +2 -0
@@ -62,6 +62,7 @@ config SANDBOX bool "Sandbox" select SUPPORT_OF_CONTROL select DM + select DM_KEYBOARD select DM_SPI_FLASH select DM_SERIAL select DM_I2C
@@ -83,6 +84,7 @@ config X86 select HAVE_PRIVATE_LIBGCC select SUPPORT_OF_CONTROL select DM + select DM_KEYBOARD select DM_SERIAL select DM_GPIO select DM_SPI
arch/sandbox/Kconfig +0 -3
@@ -25,7 +25,4 @@ config PCI used on some devices to allow the CPU to communicate with its peripherals. -config DM_KEYBOARD - default y - endmenu
arch/x86/Kconfig +0 -3
@@ -549,9 +549,6 @@ config I8254_TIMER config I8042_KEYB default y -config DM_KEYBOARD - default y - config SEABIOS bool "Support booting SeaBIOS" help
Signature · 1 line
1.9.1
PATCH 2/2 input: specify the default of I8042_KEYB in more correct manner
Creating multiple entries of "config FOO" often gives us bad experiences. In this case, we should specify "default X86" as platforms that want this keyboard by default.
---
arch/x86/Kconfig | 3 --- drivers/input/Kconfig | 1 + 2 files changed, 1 insertion(+), 3 deletions(-)
arch/x86/Kconfig +0 -3
@@ -546,9 +546,6 @@ config I8254_TIMER Intel 8254 timer contains three counters which have fixed uses. Include this to have U-Boot set up the timer correctly. -config I8042_KEYB - default y - config SEABIOS bool "Support booting SeaBIOS" help
drivers/input/Kconfig +1 -0
@@ -17,6 +17,7 @@ config CROS_EC_KEYB config I8042_KEYB bool "Enable Intel i8042 keyboard support" depends on DM_KEYBOARD + default X86 help This adds a driver for the i8042 keyboard controller, allowing the keyboard to be used on devices which support this controller. The
Signature · 1 line
1.9.1
PATCH 2/2 input: specify the default of I8042_KEYB in more correct manner
Quoted 3 lines · Masahiro Yamada
Creating multiple entries of "config FOO" often gives us bad experiences. In this case, we should specify "default X86" as platforms that want this keyboard by default.
Yep, I like this patch:
btw on some of my computers , the 8042 is physically removable ;-)
Quoted 34 lines
Signed-off-by Masahiro Yamada <[email protected]>---
arch/x86/Kconfig | 3 --- drivers/input/Kconfig | 1 + 2 files changed, 1 insertion(+), 3 deletions(-)arch/x86/Kconfig +0
-3@@ -546,9 +546,6 @@ config I8254_TIMER Intel 8254 timer contains three counters which have fixed uses. Include this to have U-Boot set up the timer correctly. -config I8042_KEYB - default y - config SEABIOS bool "Support booting SeaBIOS" helpdrivers/input/Kconfig +1
-0@@ -17,6 +17,7 @@ config CROS_EC_KEYB config I8042_KEYB bool "Enable Intel i8042 keyboard support" depends on DM_KEYBOARD + default X86 help This adds a driver for the i8042 keyboard controller, allowing the keyboard to be used on devices which support this controller. The
Signature · 2 lines
Best regards, Marek Vasut
PATCH 2/2 input: specify the default of I8042_KEYB in more correct manner
In reply to Masahiro YamadaHi Masahiro,
Quoted 30 lines · Masahiro Yamada
Creating multiple entries of "config FOO" often gives us bad experiences. In this case, we should specify "default X86" as platforms that want this keyboard by default.
Signed-off-by Masahiro Yamada <[email protected]>---
arch/x86/Kconfig | 3 --- drivers/input/Kconfig | 1 + 2 files changed, 1 insertion(+), 3 deletions(-)arch/x86/Kconfig +0
-3@@ -546,9 +546,6 @@ config I8254_TIMER Intel 8254 timer contains three counters which have fixed uses. Include this to have U-Boot set up the timer correctly. -config I8042_KEYB - default y - config SEABIOS bool "Support booting SeaBIOS" helpdrivers/input/Kconfig +0
-0
drivers/input/Kconfig config CROS_EC_KEYB · line 20
Quoted 4 lines
drivers/input/Kconfig +1
-0@@ -17,6 +17,7 @@ config CROS_EC_KEYB config I8042_KEYB bool "Enable Intel i8042 keyboard support" depends on DM_KEYBOARD + default X86
What does this mean?
Quoted 6 lines
drivers/input/Kconfig +0
-1help This adds a driver for the i8042 keyboard controller, allowing the keyboard to be used on devices which support this controller. The --1.9.1
Regards,
Simon
PATCH 2/2 input: specify the default of I8042_KEYB in more correct manner
2016-09-19 9:57 GMT+09:00 Simon Glass <[email protected]>:
Quoted 32 lines
Hi Masahiro,
Quoted 28 lines · Masahiro Yamada
Creating multiple entries of "config FOO" often gives us bad experiences. In this case, we should specify "default X86" as platforms that want this keyboard by default.
Signed-off-by Masahiro Yamada <[email protected]>---
arch/x86/Kconfig | 3 --- drivers/input/Kconfig | 1 + 2 files changed, 1 insertion(+), 3 deletions(-)arch/x86/Kconfig +0
-3@@ -546,9 +546,6 @@ config I8254_TIMER Intel 8254 timer contains three counters which have fixed uses. Include this to have U-Boot set up the timer correctly. -config I8042_KEYB - default y - config SEABIOS bool "Support booting SeaBIOS" helpdrivers/input/Kconfig +0
-1--- a/drivers/input/Kconfig
Quoted 8 lines
drivers/input/Kconfig config CROS_EC_KEYB · line 20
Quoted 6 lines
+++ b/drivers/input/Kconfig
drivers/input/Kconfig +1
-0@@ -17,6 +17,7 @@ config CROS_EC_KEYB config I8042_KEYB bool "Enable Intel i8042 keyboard support" depends on DM_KEYBOARD + default X86What does this mean?
The default value of I8042_KEYB is the
value of X86.
In another expression,
default y if X86
Signature · 2 lines
Best Regards Masahiro Yamada
PATCH 2/2 input: specify the default of I8042_KEYB in more correct manner
Quoted 43 lines · Masahiro Yamada
2016-09-19 9:57 GMT+09:00 Simon Glass <[email protected]>:
Quoted 32 lines
Hi Masahiro,
Quoted 28 lines · Masahiro Yamada
Creating multiple entries of "config FOO" often gives us bad experiences. In this case, we should specify "default X86" as platforms that want this keyboard by default.
Signed-off-by Masahiro Yamada <[email protected]>---
arch/x86/Kconfig | 3 --- drivers/input/Kconfig | 1 + 2 files changed, 1 insertion(+), 3 deletions(-)arch/x86/Kconfig +0
-3@@ -546,9 +546,6 @@ config I8254_TIMER Intel 8254 timer contains three counters which have fixed uses. Include this to have U-Boot set up the timer correctly. -config I8042_KEYB - default y - config SEABIOS bool "Support booting SeaBIOS" helpdrivers/input/Kconfig +0
-1--- a/drivers/input/KconfigQuoted 8 lines
drivers/input/Kconfig config CROS_EC_KEYB · line 20
Quoted 6 lines
+++ b/drivers/input/Kconfig
drivers/input/Kconfig +1
-0@@ -17,6 +17,7 @@ config CROS_EC_KEYB config I8042_KEYB bool "Enable Intel i8042 keyboard support" depends on DM_KEYBOARD + default X86What does this mean?
Quoted 7 lines
The default value of
I8042_KEYBis the
value of X86.In another expression,
default y if X86
Ah OK, thanks.
Regards,
Simon
PATCH 2/2 input: specify the default of I8042_KEYB in more correct manner
In reply to Masahiro YamadaQuoted 7 lines · Masahiro Yamada
Creating multiple entries of "config FOO" often gives us bad experiences. In this case, we should specify "default X86" as platforms that want this keyboard by default.
Signed-off-by Masahiro Yamada <[email protected]>Acked-by Marek Vasut <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161003/dc9447fe/attachment.sig>
PATCH 1/2 sandbox, x86: select DM_KEYBOARD instead of default y entry
In reply to Masahiro YamadaQuoted 5 lines · Masahiro Yamada
Once we migrate to DM-based drivers, we cannot go back to legacy ones, i.e. config options like DM_* are not user-configurable.
Make SANDBOX and X86 select
DM_KEYBOARDlike other platforms do.
Quoted 7 lines
Signed-off-by Masahiro Yamada <[email protected]>---
arch/Kconfig | 2 ++ arch/sandbox/Kconfig | 3 --- arch/x86/Kconfig | 3 --- 3 files changed, 2 insertions(+), 6 deletions(-)
PATCH 1/2 sandbox, x86: select DM_KEYBOARD instead of default y entry
In reply to Masahiro YamadaQuoted 7 lines · Masahiro Yamada
Once we migrate to DM-based drivers, we cannot go back to legacy ones, i.e. config options like DM_* are not user-configurable.
Make SANDBOX and X86 select
DM_KEYBOARDlike other platforms do.Signed-off-by Masahiro Yamada <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161003/795bd0f0/attachment.sig>