Skip to contentSkip to conversation

staging: ks7010: Add blank line after variable declarations.

PATCH Superseded Elise Lennion 3 participants 4 messages Oct 5, 2016 – Oct 10, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: ks7010: Add blank line after variable declarations.

Fix checkpatch WARNING: Missing a blank line after declarations.

---
 drivers/staging/ks7010/ks7010_sdio.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/ks7010/ks7010_sdio.c +1 -0
index 81c46f4..db5e632 100644
@@ -1117,6 +1117,7 @@ static void ks7010_sdio_remove(struct sdio_func *func)
 	int ret;
 	struct ks_sdio_card *card;
 	struct ks_wlan_private *priv;
+
 	DPRINTK(1, "ks7010_sdio_remove()\n");
 
 	card = sdio_get_drvdata(func);
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 6 lines · Elise Lennion

Fix checkpatch WARNING: Missing a blank line after declarations.

---
 drivers/staging/ks7010/ks7010_sdio.c | 1 +
 1 file changed, 1 insertion(+)

You need to say what changed in v2, otherwise we have no idea :(

#2 lore raw
Quoted 2 lines · Greg KH

You need to say what changed in v2, otherwise we have no idea :(

In this one I just fixed my name, was signing with my git username before.

Is just replying this e-mail enough? Also sent another patch with the same subject and the v2 description included.

thanks,

elise

#3 lore raw
Quoted 8 lines · Elise Lennion
Quoted 2 lines · Greg KH

You need to say what changed in v2, otherwise we have no idea :(

In this one I just fixed my name, was signing with my git username before.

Is just replying this e-mail enough? Also sent another patch with the same subject and the v2 description included.

It's better to just always send a v2.

julia

Quoted 12 lines

thanks,

elise

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161010034546.GA5524%40lennorien.com.
For more options, visit https://groups.google.com/d/optout.