Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding
Subsystems (2)
PATCH 1/1 Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding
style issue
Fixed coding style issue
--- drivers/staging/fbtft/fb_s6d02a1.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-)
drivers/staging/fbtft/fb_s6d02a1.c +20 -10
@@ -30,20 +30,27 @@ static int default_init_sequence[] = {-1 ,0xfc ,0x5a ,0x5a , --1 ,0xfa ,0x02 ,0x1f ,0x00 ,0x10 ,0x22 ,0x30 ,0x38 ,0x3A ,0x3A ,0x3A ,0x3A ,0x3A ,0x3d ,0x02 ,0x01 , +-1 ,0xfa ,0x02 ,0x1f ,0x00 ,0x10 ,0x22 ,0x30 ,0x38 ,0x3A ,0x3A ,0x3A , +0x3A ,0x3A ,0x3d ,0x02 ,0x01 , --1 ,0xfb ,0x21 ,0x00 ,0x02 ,0x04 ,0x07 ,0x0a ,0x0b ,0x0c ,0x0c ,0x16 ,0x1e ,0x30 ,0x3f ,0x01 ,0x02 , +-1 ,0xfb ,0x21 ,0x00 ,0x02 ,0x04 ,0x07 ,0x0a ,0x0b ,0x0c ,0x0c ,0x16 , +0x1e ,0x30 ,0x3f ,0x01 ,0x02 ,/* power setting sequence */ --1 ,0xfd ,0x00 ,0x00 ,0x00 ,0x17 ,0x10 ,0x00 ,0x01 ,0x01 ,0x00 ,0x1f ,0x1f , +-1 ,0xfd ,0x00 ,0x00 ,0x00 ,0x17 ,0x10 ,0x00 ,0x01 ,0x01 ,0x00 ,0x1f , +0x1f , --1 ,0xf4 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x3f ,0x3f ,0x07 ,0x00 ,0x3C ,0x36 ,0x00 ,0x3C ,0x36 ,0x00 , +-1 ,0xf4 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x3f ,0x3f ,0x07 ,0x00 ,0x3C , +0x36 ,0x00 ,0x3C ,0x36 ,0x00 , --1 ,0xf5 ,0x00 ,0x70 ,0x66 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x6d ,0x66 ,0x06 , +-1 ,0xf5 ,0x00 ,0x70 ,0x66 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 , +0x00 ,0x6d ,0x66 ,0x06 , --1 ,0xf6 ,0x02 ,0x00 ,0x3f ,0x00 ,0x00 ,0x00 ,0x02 ,0x00 ,0x06 ,0x01 ,0x00 , +-1 ,0xf6 ,0x02 ,0x00 ,0x3f ,0x00 ,0x00 ,0x00 ,0x02 ,0x00 ,0x06 ,0x01 , +0x00 , --1 ,0xf2 ,0x00 ,0x01 ,0x03 ,0x08 ,0x08 ,0x04 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x01 ,0x00 ,0x00 ,0x04 ,0x08 ,0x08 , +-1 ,0xf2 ,0x00 ,0x01 ,0x03 ,0x08 ,0x08 ,0x04 ,0x00 ,0x00 ,0x00 , +0x00 ,0x00 ,0x01 ,0x00 ,0x00 ,0x04 ,0x08 ,0x08 , -1, 0xf8, 0x11,
@@ -63,7 +70,8 @@ static int default_init_sequence[] = {-1 ,0xf3 ,0x00 ,0x0f ,-2 ,50 , --1 ,0xf4 ,0x00 ,0x04 ,0x00 ,0x00 ,0x00 ,0x3f ,0x3f ,0x07 ,0x00 ,0x3C ,0x36 ,0x00 ,0x3C ,0x36 ,0x00 , +-1 ,0xf4 ,0x00 ,0x04 ,0x00 ,0x00 ,0x00 ,0x3f ,0x3f ,0x07 , +0x00 ,0x3C ,0x36 ,0x00 ,0x3C ,0x36 ,0x00 ,-2 ,50 , -1, 0xf3, 0x00, 0x1f,
@@ -74,9 +82,11 @@ static int default_init_sequence[] = {-1 ,0xf3 ,0x00 ,0xff ,-2 ,50 , --1 ,0xfd ,0x00 ,0x00 ,0x00 ,0x17 ,0x10 ,0x00 ,0x00 ,0x01 ,0x00 ,0x16 ,0x16 , +-1 ,0xfd ,0x00 ,0x00 ,0x00 ,0x17 ,0x10 ,0x00 ,0x00 ,0x01 , +0x00 ,0x16 ,0x16 , --1 ,0xf4 ,0x00 ,0x09 ,0x00 ,0x00 ,0x00 ,0x3f ,0x3f ,0x07 ,0x00 ,0x3C ,0x36 ,0x00 ,0x3C ,0x36 ,0x00 , +-1 ,0xf4 ,0x00 ,0x09 ,0x00 ,0x00 ,0x00 ,0x3f ,0x3f ,0x07 ,0x00 ,0x3C , +0x36 ,0x00 ,0x3C ,0x36 ,0x00 , /* initializing sequence */
Signature · 1 line
2.7.4
Greg KH
maintainerQuoted 3 lines · Nadim Almas
style issue
Fixed coding style issue
This does not seem like valid sentances that mean much to me. Do they to you?
Quoted 11 lines
Signed-off-by Nadim Almas <[email protected]>--- drivers/staging/fbtft/fb_s6d02a1.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-)drivers/staging/fbtft/fb_s6d02a1.c +0
-0
drivers/staging/fbtft/fb_s6d02a1.c static int default_init_sequence[] = { · line 34
Quoted 6 lines
drivers/staging/fbtft/fb_s6d02a1.c +2
-1@@ -30,20 +30,27 @@ static int default_init_sequence[] = {-1 ,0xfc ,0x5a ,0x5a , - -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A, 0x3A, 0x3A, 0x3d, 0x02, 0x01, +-1 ,0xfa ,0x02 ,0x1f ,0x00 ,0x10 ,0x22 ,0x30 ,0x38 ,0x3A ,0x3A ,0x3A , + 0x3A, 0x3A, 0x3d, 0x02, 0x01,
This looks worse to me now, remember, checkpatch.pl is a "hint", not a hard-and-fast-rule. Use it wisely.
greg k-h
why its seems worst to you i am just removing "80 character line limit coding style"
for the last 3 months I am trying to submit my first patch but patch is not accepted by you by giving reason i can't able to understand please help me
Quoted 30 lines · Greg KH
Quoted 3 lines · Nadim Almas
style issue
Fixed coding style issue
This does not seem like valid sentances that mean much to me. Do they to you?
Quoted 11 lines
Signed-off-by Nadim Almas <[email protected]>--- drivers/staging/fbtft/fb_s6d02a1.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-)drivers/staging/fbtft/fb_s6d02a1.c +0
-0drivers/staging/fbtft/fb_s6d02a1.c static int default_init_sequence[] = { · line 34
Quoted 6 lines
drivers/staging/fbtft/fb_s6d02a1.c +2
-1@@ -30,20 +30,27 @@ static int default_init_sequence[] = {-1 ,0xfc ,0x5a ,0x5a , - -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A, 0x3A, 0x3A, 0x3d, 0x02, 0x01, +-1 ,0xfa ,0x02 ,0x1f ,0x00 ,0x10 ,0x22 ,0x30 ,0x38 ,0x3A ,0x3A ,0x3A , + 0x3A, 0x3A, 0x3d, 0x02, 0x01,This looks worse to me now, remember, checkpatch.pl is a "hint", not a hard-and-fast-rule. Use it wisely.
greg k-h
Quoted 5 lines · Nadim Almas
why its seems worst to you i am just removing "80 character line limit coding style"
for the last 3 months I am trying to submit my first patch but patch is not accepted by you by giving reason i can't able to understand please help me
Taste in improving code is a difficult thing to acquire, determine and utilize.
Keep on trying to improve the code and not just in ways that shut-up brainless tools.
Please consider the difference between your initial patch and this proposal: https://patchwork.kernel.org/patch/9367167/
Apologies for not cc'ing you as your patch was what caused me to look at this code at all.
Quoted 31 lines · Greg KH
Quoted 30 lines · Nadim Almas
Quoted 3 lines
style issue
Fixed coding style issue
This does not seem like valid sentances that mean much to me. Do they to you?
Quoted 11 lines
Signed-off-by Nadim Almas <[email protected]>--- drivers/staging/fbtft/fb_s6d02a1.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-)drivers/staging/fbtft/fb_s6d02a1.c +0
-0drivers/staging/fbtft/fb_s6d02a1.c static int default_init_sequence[] = { · line 34
Quoted 6 lines
drivers/staging/fbtft/fb_s6d02a1.c +2
-1@@ -30,20 +30,27 @@ static int default_init_sequence[] = {-1 ,0xfc ,0x5a ,0x5a , - -1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A, 0x3A, 0x3A, 0x3d, 0x02, 0x01, +-1 ,0xfa ,0x02 ,0x1f ,0x00 ,0x10 ,0x22 ,0x30 ,0x38 ,0x3A ,0x3A ,0x3A , + 0x3A, 0x3A, 0x3d, 0x02, 0x01,This looks worse to me now, remember, checkpatch.pl is a "hint", not a hard-and-fast-rule. Use it wisely.