Skip to contentSkip to conversation

boot/uboot: Call 'make all' unconditionally

PATCH New Fabio Estevam 2 participants 2 messages Oct 7, 2016

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH v3 1/1 boot/uboot: Call 'make all' unconditionally

Since commit fad58cefa4a392b ("boot/uboot: allow to build multiple U-Boot images") the installation of SPL binary fails.

For example, when building the mx6cubox_defconfig target we see:

LD u-boot
OBJCOPY u-boot-nodtb.bin
COPY u-boot.bin
MKIMAGE u-boot.img

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

uboot 2016.09.01 Installing to target
uboot 2016.09.01 Installing to images directory

cp -dpf /home/fabio/buildroot/output/build/uboot-2016.09.01/u-boot.bin /home/fabio/buildroot/output/images/ cp -dpf /home/fabio/buildroot/output/build/uboot-2016.09.01/u-boot.img /home/fabio/buildroot/output/images/ cp -dpf /home/fabio/buildroot/output/build/uboot-2016.09.01/SPL /home/fabio/buildroot/output/images/
cp: cannot stat '/home/fabio/buildroot/output/build/uboot-2016.09.01/SPL': No such file or directory

Instead of calling 'make all' only for the BR2_TARGET_UBOOT_FORMAT_DTB_IMG case, call 'make all' unconditionally so that the SPL target can also be installed.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v2:
- Call 'make all' unconditionally

 boot/uboot/uboot.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
boot/uboot/uboot.mk +4 -1
index 7379a4d..86e5b84 100644
@@ -48,6 +48,9 @@ UBOOT_MAKE_TARGET += mdbtrick
 endif
 endif
 
+# Call 'make all' unconditionally
+UBOOT_MAKE_TARGET += all
+
 ifeq ($(BR2_TARGET_UBOOT_FORMAT_KWB),y)
 UBOOT_BINS += u-boot.kwb
 UBOOT_MAKE_TARGET += u-boot.kwb

@@ -68,7 +71,7 @@ endif
 
 ifeq ($(BR2_TARGET_UBOOT_FORMAT_DTB_IMG),y)
 UBOOT_BINS += u-boot-dtb.img
-UBOOT_MAKE_TARGET += all u-boot-dtb.img
+UBOOT_MAKE_TARGET += u-boot-dtb.img
 endif
 
 ifeq ($(BR2_TARGET_UBOOT_FORMAT_IMG),y)
Signature · 1 line
2.7.4
Applied
#1 lore raw

PATCH v3 1/1 boot/uboot: Call 'make all' unconditionally

Hello,

Quoted 20 lines · Fabio Estevam

Since commit fad58cefa4a392b ("boot/uboot: allow to build multiple U-Boot images") the installation of SPL binary fails.

For example, when building the mx6cubox_defconfig target we see:

LD u-boot
OBJCOPY u-boot-nodtb.bin
COPY u-boot.bin
MKIMAGE u-boot.img

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

uboot 2016.09.01 Installing to target
uboot 2016.09.01 Installing to images directory

cp -dpf /home/fabio/buildroot/output/build/uboot-2016.09.01/u-boot.bin /home/fabio/buildroot/output/images/ cp -dpf /home/fabio/buildroot/output/build/uboot-2016.09.01/u-boot.img /home/fabio/buildroot/output/images/ cp -dpf /home/fabio/buildroot/output/build/uboot-2016.09.01/SPL /home/fabio/buildroot/output/images/
cp: cannot stat '/home/fabio/buildroot/output/build/uboot-2016.09.01/SPL': No such file or directory

Instead of calling 'make all' only for the BR2_TARGET_UBOOT_FORMAT_DTB_IMG case, call 'make all' unconditionally so that the SPL target can also be installed.

Quoted 7 lines
Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v2:
- Call 'make all' unconditionally

 boot/uboot/uboot.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com