Enable -D_SVR4_2 for compilation on Solaris
PATCH 1/1 Enable -D_SVR4_2 for compilation on Solaris
Solaris' header files to not make necessary macros (like CMSG_SPACE) available unless told "this is the API level we want" - thus, do so.
This fixes --multihome on OpenSolaris 11 (at least).
trac #750
--- configure.ac | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
configure.ac +1 -0
@@ -318,6 +318,7 @@ case "$host" in *-*-solaris*) AC_DEFINE([TARGET_SOLARIS], [1], [Are we running on Solaris?]) AC_DEFINE_UNQUOTED([TARGET_PREFIX], ["S"], [Target prefix]) + CPPFLAGS="$CPPFLAGS -D_XPG4_2" ;; *-*-openbsd*) AC_DEFINE([TARGET_OPENBSD], [1], [Are we running on OpenBSD?])
Signature · 1 line
1.5.6.5
I cannot test Solaris but the code looks good enough, so ACK
Arne
Am 10.10.16 um 09:39 schrieb Gert Doering:
Quoted 24 lines
Solaris' header files to not make necessary macros (like
CMSG_SPACE) available unless told "this is the API level we want" - thus, do so.This fixes --multihome on OpenSolaris 11 (at least).
trac #750
Signed-off-by Gert Doering <[email protected]...>--- configure.ac | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)configure.ac +1
-0@@ -318,6 +318,7 @@ case "$host" in *-*-solaris*) AC_DEFINE([TARGET_SOLARIS], [1], [Are we running on Solaris?]) AC_DEFINE_UNQUOTED([TARGET_PREFIX], ["S"], [Target prefix]) + CPPFLAGS="$CPPFLAGS -D_XPG4_2" ;; *-*-openbsd*) AC_DEFINE([TARGET_OPENBSD], [1], [Are we running on OpenBSD?])
Your patch has been applied to the master branch.
commit 6eaa70e80aea7dfd1b3114fcb369a8f72c19ceee
Author: Gert Doering Date: Mon Oct 10 09:39:31 2016 +0200
Enable -D_SVR4_2 for compilation on Solaris
Signed-off-by: Gert Doering <[email protected]...>
Acked-by: Arne Schwabe <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg12634.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
Am 10.10.2016 um 09:39 schrieb Gert Doering:
configure.ac case "$host" in · line 321
Quoted 1 line
configure.ac +1
-0+ CPPFLAGS="$CPPFLAGS -D_XPG4_2"
NAK. Description mismatches content. Please revert and reapply with proper description.
Hi,
Quoted 4 lines · Matthias Andree
Am 10.10.2016 um 09:39 schrieb Gert Doering:
configure.ac case "$host" in · line 321
Quoted 1 line
configure.ac +1
-0+ CPPFLAGS="$CPPFLAGS -D_XPG4_2"NAK. Description mismatches content. Please revert and reapply with proper description.
Indeed. Silly me. So much effort for a one-line change.
Thanks for pointing that out.
commit 4e2038ed2e77aa7189852304d802382bad140f53
Author: Gert Doering <[email protected]...> Date: Mon Oct 10 09:39:31 2016 +0200
Enable -D_XPG4_2 for compilation on Solaris
...
(v2: same patch as in 6eaa70e80aea7, reverted in e25d03a4cc0, and now with correct description)
commit e25d03a4cc0664f6ece067facb1bc8e38134f396
Author: Gert Doering <[email protected]...> Date: Mon Oct 10 19:36:20 2016 +0200
Revert "Enable -D_SVR4_2 for compilation on Solaris"
This reverts commit 6eaa70e80aea7dfd1b3114fcb369a8f72c19ceee. (the description was incorrect and the patch was already pushed out)
gert
Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany [email protected]...
fax: +49-89-35655025 [email protected]...