rxrpc: Add some additional call tracing
Hello David Howells,
The patch a84a46d73050: "rxrpc: Add some additional call tracing" from Sep 17, 2016, leads to the following static checker warning:
net/rxrpc/call_object.c:279 rxrpc_new_client_call() warn: passing zero to 'ERR_PTR'
net/rxrpc/call_object.c
270
271 /* Set up or get a connection record and set the protocol parameters,
272 * including channel number and call ID.
273 */
274 ret = rxrpc_connect_call(call, cp, srx, gfp);
275 if (ret < 0)
276 goto error;
277
278 trace_rxrpc_call(call, rxrpc_call_connected, atomic_read(&call->usage),
279 here, ERR_PTR(ret));
^^^^^^^^^^^^Pointless.
280
regards,
dan carpenter
Quoted 4 lines · Dan Carpenter
278 trace_rxrpc_call(call, rxrpc_call_connected, atomic_read(&call->usage), 279 here, ERR_PTR(ret)); ^^^^^^^^^^^^Pointless.
I guess I should just cast it instead.
David
Quoted 8 lines · David Howells
Quoted 4 lines · Dan Carpenter
278 trace_rxrpc_call(call, rxrpc_call_connected, atomic_read(&call->usage), 279 here, ERR_PTR(ret)); ^^^^^^^^^^^^Pointless.
I guess I should just cast it instead.
It's just zero or NULL always. But if you want you can also ignore the static checker warning since it's obviously harmless.
regards,
dan carpenter
Quoted 2 lines · Dan Carpenter
It's just zero or NULL always. But if you want you can also ignore the static checker warning since it's obviously harmless.
Ah, yes. The trace line used to be before the error check, but now there's a separate trace line for that.
David