Skip to contentSkip to conversation

net: thunderx: Add RGMII interface type support

bug report Dan Carpenter 1 participant 1 message Oct 12, 2016 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hello Sunil Goutham,

This is a semi-automatic email about new static checker warnings.

The patch 6465859aba1e: "net: thunderx: Add RGMII interface type support" from Aug 12, 2016, leads to the following Smatch complaint:

drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119 xcv_setup_link()
error: we previously assumed 'xcv' could be null (see line 118)

drivers/net/ethernet/cavium/thunder/thunder_xcv.c
117

   118		if (!xcv) {
                     ^^^

check.

119 dev_err(&xcv->pdev->dev,

                                 ^^^^^^^^^^^^^^

dereference.

120 "XCV init not done, probe may have failed\n");
121 return;

regards,
dan carpenter