staging: android/ion: testing the wrong variable
Subsystems (2)
PATCH 1/1 staging: android/ion: testing the wrong variable
We're testing "pdev" but we intended to test "heap_pdev". This is a static checker fix and it's unlikely that anyone is affected by this bug.
Fixes 13439479c7de ('staging: ion: Add files for parsing the devicetree')
Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/android/ion/ion_of.c +1 -1
@@ -107,7 +107,7 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, heap_pdev =of_platform_device_create (node, heaps[i].name, &pdev->dev); -if (!pdev) +if (!heap_pdev)return ERR_PTR (-ENOMEM ); heap_pdev->dev.platform_data = &heaps[i];
Quoted 7 lines · Dan Carpenter
We're testing "pdev" but we intended to test "
heap_pdev". This is a static checker fix and it's unlikely that anyone is affected by this bug.Fixes 13439479c7de ('staging: ion: Add files for parsing the devicetree')Signed-off-by Dan Carpenter <[email protected]>
Acked-by Laura Abbott <[email protected]>
Quoted 14 lines
drivers/staging/android/ion/ion_of.c +1
-1@@ -107,7 +107,7 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, heap_pdev =of_platform_device_create (node, heaps[i].name, &pdev->dev); -if (!pdev) +if (!heap_pdev)return ERR_PTR (-ENOMEM ); heap_pdev->dev.platform_data = &heaps[i];