Skip to contentSkip to conversation

gpio: stmpe: || vs && typo

PATCH In review Dan Carpenter 3 participants 3 messages Oct 12, 2016

Subsystems (3)
Kernel janitors GPIO Arm STM32
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 gpio: stmpe: || vs && typo

&& was obviously intended here.

Fixes 6936e1f88d23 ('gpio: stmpe: Write int status register only when needed')
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpio/gpio-stmpe.c +1 -1
index e7d422a..5b00427 100644
@@ -409,7 +409,7 @@ static irqreturn_t stmpe_gpio_irq(int irq, void *dev)
 		 * 801/1801/1600, bits are cleared when read.
 		 * Edge detect register is not present on 801/1600/1801
 		 */
-		if (stmpe->partnum != STMPE801 || stmpe->partnum != STMPE1600 ||
+		if (stmpe->partnum != STMPE801 && stmpe->partnum != STMPE1600 &&
 		    stmpe->partnum != STMPE1801) {
 			stmpe_reg_write(stmpe, statmsbreg + i, status[i]);
 			stmpe_reg_write(stmpe,
Acked-by on v1 1/1
#1 lore raw

Hi Dan

Quoted 11 lines · Dan Carpenter

&& was obviously intended here.

Fixes 6936e1f88d23 ('gpio: stmpe: Write int status register only when needed')
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpio/gpio-stmpe.c +0 -0
index e7d422a..5b00427 100644

drivers/gpio/gpio-stmpe.c static irqreturn_t stmpe_gpio_irq(int irq, void *dev) · line 415

Quoted 8 lines
drivers/gpio/gpio-stmpe.c +1 -1
@@ -409,7 +409,7 @@ static irqreturn_t stmpe_gpio_irq(int irq, void *dev)
 		 * 801/1801/1600, bits are cleared when read.
 		 * Edge detect register is not present on 801/1600/1801
 		 */
-		if (stmpe->partnum != STMPE801 || stmpe->partnum != STMPE1600 ||
+		if (stmpe->partnum != STMPE801 && stmpe->partnum != STMPE1600 &&
 		    stmpe->partnum != STMPE1801) {
 			stmpe_reg_write(stmpe, statmsbreg + i, status[i]);
 			stmpe_reg_write(stmpe,

Well spotted ;-)

Acked-by Patrice Chotard <[email protected]>

Thanks