staging: greybus: Format block comments.
Subsystems (3)
PATCH 1/7 staging: greybus: Format block comments.
Fix checkpatch warning:
WARNING: Block comments use a trailing */ on a separate line
--- drivers/staging/greybus/arche-apb-ctrl.c | 5 +++-- drivers/staging/greybus/arche-platform.c | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-)
drivers/staging/greybus/arche-apb-ctrl.c +3 -2
@@ -183,7 +183,7 @@ static int standby_boot_seq(struct platform_device *pdev)* Pasted from WDM spec, * - A falling edge on POWEROFF_L is detected (a) * - WDM enters standby mode, but no output signals are changed -* */ +*/ /* TODO: POWEROFF_L is input to WDM module */ apb->state =ARCHE_PLATFORM_STATE_STANDBY ;
@@ -286,7 +286,8 @@ static ssize_t state_store(struct device *dev,return count;/* First we want to make sure we power off everything -* and then enter FW flashing state */ +* and then enter FW flashing state +*/ poweroff_seq (pdev); ret =fw_flashing_seq (pdev); }else {
drivers/staging/greybus/arche-platform.c +2 -1
@@ -455,7 +455,8 @@ retry: goto exit;/* First we want to make sure we power off everything -* and then activate back again */ +* and then activate back again +*/ device_for_each_child (arche_pdata->dev,NULL , apb_poweroff);arche_platform_poweroff_seq (arche_pdata);
Signature · 1 line
2.7.4
Greg KH
maintainerQuoted 9 lines · Elise Lennion
Fix checkpatch warning:
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by Elise Lennion <[email protected]>--- drivers/staging/greybus/arche-apb-ctrl.c | 5 +++-- drivers/staging/greybus/arche-platform.c | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-)
Does not apply to my tree :(
Can you refresh this whole series and resend it? Keep the acks that were sent for some of the patches, and fix up the subject: lines.
thanks,
greg k-h
Quoted 6 lines · Greg KH
Does not apply to my tree :(
Can you refresh this whole series and resend it? Keep the acks that were sent for some of the patches, and fix up the subject: lines.
Ok, I'll create new patches containing the changes without ack.
This one that doesn't apply, should I just drop it? Your tree is local so I can't see what is different, to adjust the changes, until you push the changes to staging-testing, right?
thank you,
elise.
Quoted 9 lines · Elise Lennion
Quoted 6 lines · Greg KH
Does not apply to my tree :(
Can you refresh this whole series and resend it? Keep the acks that were sent for some of the patches, and fix up the subject: lines.
Ok, I'll create new patches containing the changes without ack.
Actually, Greg said to keep the acks on the patches that have been acked.
julia
Quoted 16 lines
This one that doesn't apply, should I just drop it? Your tree is local so I can't see what is different, to adjust the changes, until you push the changes to staging-testing, right?
thank you,
elise.
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161012135508.GC5158%40lennorien.com.
For more options, visit https://groups.google.com/d/optout.
Greg KH
maintainerQuoted 9 lines · Elise Lennion
Quoted 6 lines · Greg KH
Does not apply to my tree :(
Can you refresh this whole series and resend it? Keep the acks that were sent for some of the patches, and fix up the subject: lines.
Ok, I'll create new patches containing the changes without ack.
No, keep the acks, why delete them?
Quoted 3 lines
This one that doesn't apply, should I just drop it? Your tree is local so I can't see what is different, to adjust the changes, until you push the changes to staging-testing, right?
My tree is pushed to staging-testing, so you should see this now. Is it not synced up somehow?
thanks,
greg k-h
Quoted 5 lines · Greg KH
Quoted 4 lines · Elise Lennion
Quoted 3 lines · Greg KH
Does not apply to my tree :(
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Can you refresh this whole series and resend it? Keep the acks that were sent for some of the patches, and fix up the subject: lines.
Ok, I'll create new patches containing the changes without ack.
No, keep the acks, why delete them?
I think didn't explain myself well. I meant that I'd keep the acks and send the changes of the non-acks in new patches.
The remaining commits, the ones that don't create conflicts and aren't acked yet, are all changes in greybus/camera.c. Is it ookay to create a new patchset with them?
Quoted 7 lines
Quoted 3 lines
This one that doesn't apply, should I just drop it? Your tree is local so I can't see what is different, to adjust the changes, until you push the changes to staging-testing, right?
My tree is pushed to staging-testing, so you should see this now. Is it not synced up somehow?
Yes, I had a lot of trouble syncing the local git branch but now I can see the changes :)
Quoted 3 lines
thanks,
greg k-h
Quoted 15 lines · Elise Lennion
Quoted 5 lines · Greg KH
Quoted 4 lines · Elise Lennion
Quoted 3 lines · Greg KH
Does not apply to my tree :(
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Can you refresh this whole series and resend it? Keep the acks that were sent for some of the patches, and fix up the subject: lines.
Ok, I'll create new patches containing the changes without ack.
No, keep the acks, why delete them?
Quoted 6 lines
I think didn't explain myself well. I meant that I'd keep the acks and send the changes of the non-acks in new patches.
The remaining commits, the ones that don't create conflicts and aren't acked yet, are all changes in
greybus/camera.c. Is it ookay to create a new patchset with them?
I think you should just send the same series again.
julia
Quoted 23 lines
Quoted 8 lines
Quoted 4 lines
This one that doesn't apply, should I just drop it? Your tree is local so I can't see what is different, to adjust the changes, until you push the changes to staging-testing, right?
My tree is pushed to staging-testing, so you should see this now. Is it not synced up somehow?
Yes, I had a lot of trouble syncing the local git branch but now I can see the changes :)
Quoted 3 lines
thanks,
greg k-h
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161012155247.GA12782%40lennorien.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 22 lines · Julia Lawall
Quoted 18 lines · Elise Lennion
Quoted 5 lines · Greg KH
Quoted 4 lines · Elise Lennion
Quoted 3 lines · Greg KH
Does not apply to my tree :(
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Can you refresh this whole series and resend it? Keep the acks that were sent for some of the patches, and fix up the subject: lines.
Ok, I'll create new patches containing the changes without ack.
No, keep the acks, why delete them?
I think didn't explain myself well. I meant that I'd keep the acks and send the changes of the non-acks in new patches.
Quoted 8 lines
Quoted 3 lines
The remaining commits, the ones that don't create conflicts and aren't acked yet, are all changes in
greybus/camera.c. Is it ookay to create a new patchset with them?I think you should just send the same series again.
julia
Ok, I'll resend the remaining patches.
thank you,
elise
New version of this patch:
https://groups.google.com/forum/#!topic/outreachy-kernel/mVVbHvYAg5U
Please ignore my last message.
That's the new version of the patch:
https://groups.google.com/forum/#!topic/outreachy-kernel/uulXIW-rOhY
I'll make sure my future patches are more organized.