mfd: intel-lpss: Do not put device in reset state on suspend
PATCH 1/1 mfd: intel-lpss: Do not put device in reset state on suspend
Commit 41a3da2b8e163 ("mfd: intel-lpss: Save register context on suspend") saved the register context while going to suspend and also put the device in reset state.
Due to the resetting of device, system cannot enter S3/S0ix states when no_console_suspend flag is enabled. The system and serial console both hang. The resetting of device is not needed while going to suspend. Hence remove this code.
--- drivers/mfd/intel-lpss.c | 3 --- 1 file changed, 3 deletions(-)
drivers/mfd/intel-lpss.c +0 -3
@@ -502,9 +502,6 @@ int intel_lpss_suspend(struct device *dev)for (i =0 ; i <LPSS_PRIV_REG_COUNT ; i++) lpss->priv_ctx[i] =readl (lpss->priv + i *4 ); -/* Put the device into reset state */ -writel (0 , lpss->priv +LPSS_PRIV_RESETS ); -return 0 ; }EXPORT_SYMBOL_GPL (intel_lpss_suspend);
Signature · 1 line
2.10.1
Quoted 4 lines · Azhar Shaikh
Commit
41a3da2b8e163("mfd: intel-lpss: Save register context on suspend") saved the register context while going to suspend and also put the device in reset state.
Quoted 8 lines
Due to the resetting of device, system cannot enter S3/S0ix states when
no_console_suspendflag is enabled. The system and serial console both hang. The resetting of device is not needed while going to suspend. Hence remove this code.Fixes 41a3da2b8e163 ("mfd: intel-lpss: Save register context onsuspend")
Signed-off-by Azhar Shaikh <[email protected]>
Quoted 18 lines
---
drivers/mfd/intel-lpss.c | 3 ---1 file changed, 3 deletions(-)drivers/mfd/intel-lpss.c +0
-0@@ -502,9 +502,6 @@ int intel_lpss_suspend(struct device *dev) for (i = 0; i < LPSS_PRIV_REG_COUNT; i++) lpss->priv_ctx[i] = readl(lpss->priv + i * 4);drivers/mfd/intel-lpss.c +0
-3-/* Put the device into reset state */ -writel (0 , lpss->priv +LPSS_PRIV_RESETS ); -return 0;
}
EXPORT_SYMBOL_GPL(intel_lpss_suspend);
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Quoted 11 lines · Azhar Shaikh
Commit
41a3da2b8e163("mfd: intel-lpss: Save register context on suspend") saved the register context while going to suspend and also put the device in reset state.Due to the resetting of device, system cannot enter S3/S0ix states when
no_console_suspendflag is enabled. The system and serial console both hang. The resetting of device is not needed while going to suspend. Hence remove this code.Fixes 41a3da2b8e163 ("mfd: intel-lpss: Save register context on suspend")Signed-off-by Azhar Shaikh <[email protected]>
Quoted 9 lines · Azhar Shaikh
Commit
41a3da2b8e163("mfd: intel-lpss: Save register context on suspend") saved the register context while going to suspend and also put the device in reset state.Due to the resetting of device, system cannot enter S3/S0ix states when
no_console_suspendflag is enabled. The system and serial console both hang. The resetting of device is not needed while going to suspend. Hence remove this code.
Quoted 5 lines
Fixes 41a3da2b8e163 ("mfd: intel-lpss: Save register context on suspend")Signed-off-by Azhar Shaikh <[email protected]>--- drivers/mfd/intel-lpss.c | 3 --- 1 file changed, 3 deletions(-)
Applied with Acks and sent to Stable.
Quoted 14 lines
drivers/mfd/intel-lpss.c +0
-3@@ -502,9 +502,6 @@ int intel_lpss_suspend(struct device *dev)for (i =0 ; i <LPSS_PRIV_REG_COUNT ; i++) lpss->priv_ctx[i] =readl (lpss->priv + i *4 ); -/* Put the device into reset state */ -writel (0 , lpss->priv +LPSS_PRIV_RESETS ); -return 0 ; }EXPORT_SYMBOL_GPL (intel_lpss_suspend);
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog