Skip to contentSkip to conversation

xfstests-bld: fix check script argument ordering bug

PATCH Applied Eric Whitney 2 participants 2 messages Oct 12, 2016 – Oct 14, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests-bld: fix check script argument ordering bug

The check script called by runtests.sh in the test appliance to control xfstest execution requires that all optional arguments precede any test names on its command line. Violation of this requirement results in an error message ("Arguments before tests, please!") and an immediate exit without test execution.

runtests.sh violates this requirement when it runs a specific test in a configuration that defines TEST_SET_EXCLUDE (contains -x argument).

To reproduce the bug, run "kvm-xfstests -c bigalloc generic/375".

---
 kvm-xfstests/test-appliance/files/root/runtests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kvm-xfstests/test-appliance/files/root/runtests.sh +1 -1
index a9338dc..5e6c1f7 100755
@@ -374,7 +374,7 @@ do
 	gce_run_hooks fs-config-begin $i
 	for j in $(seq 1 $RPT_COUNT) ; do
 	    gce_run_hooks pre-xfstests $i $j
-	    bash ./check -T $AEX $FSTESTSET $TEST_SET_EXCLUDE
+	    bash ./check -T $AEX $TEST_SET_EXCLUDE $FSTESTSET
 	    gce_run_hooks post-xfstests $i $j
 	    umount "$TEST_DEV" >& /dev/null
 	    check_filesystem "$TEST_DEV" >& $RESULT_BASE/fsck.out
Signature · 1 line
2.1.4
#1 lore raw
Quoted 6 lines · Eric Whitney

The check script called by runtests.sh in the test appliance to control xfstest execution requires that all optional arguments precede any test names on its command line. Violation of this requirement results in an error message ("Arguments before tests, please!") and an immediate exit without test execution.

Quoted 6 lines

runtests.sh violates this requirement when it runs a specific test in a configuration that defines TEST_SET_EXCLUDE (contains -x argument).

To reproduce the bug, run "kvm-xfstests -c bigalloc generic/375".

Thanks, applied!

- Ted