Skip to contentSkip to conversation

Staging: lustre: indent an if statement

PATCH In review Dan Carpenter 3 participants 4 messages Oct 13, 2016 – Oct 14, 2016

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 Staging: lustre: indent an if statement

This if statement wasn't intended.

Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/lustre/lustre/obdclass/cl_object.c +1 -1
index 3199dd4..a102c36 100644
@@ -335,7 +335,7 @@ int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj,
 		if (obj->co_ops->coo_getstripe) {
 			result = obj->co_ops->coo_getstripe(env, obj, uarg);
 			if (result)
-			break;
+				break;
 		}
 	}
 	return result;
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines

This if statement wasn't intended.

Acked-by James Simmons <[email protected]>
Quoted 16 lines
Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/lustre/lustre/obdclass/cl_object.c +1 -1
index 3199dd4..a102c36 100644
@@ -335,7 +335,7 @@ int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj,
 		if (obj->co_ops->coo_getstripe) {
 			result = obj->co_ops->coo_getstripe(env, obj, uarg);
 			if (result)
-			break;
+				break;
 		}
 	}
 	return result;
#2 lore raw
Quoted 1 line · James Simmons
Quoted 1 line

This if statement wasn't intended.

just to be sure: in conjunction with the subject of the mail this should read "indented" instead of "intended", right?
- otherwise this would result in a slightly different patch...

Quoted 22 lines
Acked-by James Simmons <[email protected]>
Quoted 8 lines
Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/lustre/lustre/obdclass/cl_object.c +0 -0
index 3199dd4..a102c36 100644

drivers/staging/lustre/lustre/obdclass/cl_object.c int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj, · line 341

Quoted 8 lines
drivers/staging/lustre/lustre/obdclass/cl_object.c +1 -1
@@ -335,7 +335,7 @@ int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj,
 		if (obj->co_ops->coo_getstripe) {
 			result = obj->co_ops->coo_getstripe(env, obj, uarg);
 			if (result)
-			break;
+				break;
 		}
 	}
 	return result;

_______________________________________________
lustre-devel mailing list
[email protected]
http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org

author
#3 lore raw
Quoted 4 lines · Martin Hecht
Quoted 1 line · James Simmons
Quoted 1 line

This if statement wasn't intended.

just to be sure: in conjunction with the subject of the mail this should read "indented" instead of "intended", right?

Yes, yes. I should just avoid both words from now on because my fingers constantly get mixed up.

Greg already applied this so it's too late to send a v2.

regards,
dan carpenter