perf: xgene: Remove bogus IS_ERR() check
PATCH 1/1 perf: xgene: Remove bogus IS_ERR() check
This patch fixes the warning issue with static checker. The bug is reported in [1]
[1] https://www.spinics.net/lists/arm-kernel/msg535957.html
--- drivers/perf/xgene_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/perf/xgene_pmu.c +1 -1
@@ -1011,7 +1011,7 @@ xgene_pmu_dev_ctx *acpi_get_pmu_hw_inf(struct xgene_pmu *xgene_pmu, rc =acpi_dev_get_resources (adev, &resource_list, acpi_pmu_dev_add_resource, &res);acpi_dev_free_resource_list (&resource_list); -if (rc <0 ||IS_ERR (&res)) { +if (rc <0 ) {dev_err (dev,"PMU type %d: No resource address found\n" , type); goto err; }
Signature · 1 line
1.9.1
Mark Rutland
maintainerPATCH 1/1 perf: xgene: Remove bogus IS_ERR() check
Quoted 6 lines · Tai Nguyen
This patch fixes the warning issue with static checker. The bug is reported in [1]
[1] https://www.spinics.net/lists/arm-kernel/msg535957.html
Signed-off-by Tai Nguyen <[email protected]>
Please put the problem description in the commit message:
In acpi_get_pmu_hw_inf we pass the address of a local variable to IS_ERR(), which doesn't make sense, as the pointer must be a real, valid pointer. This doesn't cause a functional problem, as IS_ERR() will evaluate as false, but the check is bogus and causes static checkers to complain.
Remove the bogus check.
Please also add a Reported-by for Dan.
The patch itself is fine, so with the above, you can add:
Please Cc Will Deacon when sending that, I expect that he will pick it up (though perhaps not until rc1 given this is not a critical issue).
Thanks,
Mark.
Quoted 20 lines
--- drivers/perf/xgene_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/perf/xgene_pmu.c +1
-1@@ -1011,7 +1011,7 @@ xgene_pmu_dev_ctx *acpi_get_pmu_hw_inf(struct xgene_pmu *xgene_pmu, rc =acpi_dev_get_resources (adev, &resource_list, acpi_pmu_dev_add_resource, &res);acpi_dev_free_resource_list (&resource_list); -if (rc <0 ||IS_ERR (&res)) { +if (rc <0 ) {dev_err (dev,"PMU type %d: No resource address found\n" , type); goto err; }Signature · 1 line
1.9.1
PATCH 1/1 perf: xgene: Remove bogus IS_ERR() check
Hi Mark,
Quoted 17 lines · Mark Rutland
Quoted 6 lines · Tai Nguyen
This patch fixes the warning issue with static checker. The bug is reported in [1]
[1] https://www.spinics.net/lists/arm-kernel/msg535957.html
Signed-off-by Tai Nguyen <[email protected]>Please put the problem description in the commit message:
In
acpi_get_pmu_hw_infwe pass the address of a local variable toIS_ERR(), which doesn't make sense, as the pointer must be a real, valid pointer. This doesn't cause a functional problem, asIS_ERR()will evaluate as false, but the check is bogus and causes static checkers to complain.Remove the bogus check.
Quoted 9 lines
Please also add a Reported-by for Dan.
The patch itself is fine, so with the above, you can add:
Acked-by Mark Rutland <[email protected]>Please Cc Will Deacon when sending that, I expect that he will pick it up (though perhaps not until rc1 given this is not a critical issue).
Thanks. I'll send the updated patch shortly.
Regards,
Tai
[...]
Quoted 20 lines
Quoted 20 lines
--- drivers/perf/xgene_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/perf/xgene_pmu.c +1
-2@@ -1011,7 +1011,7 @@ xgene_pmu_dev_ctx *acpi_get_pmu_hw_inf(struct xgene_pmu *xgene_pmu, rc =acpi_dev_get_resources (adev, &resource_list, acpi_pmu_dev_add_resource, &res);acpi_dev_free_resource_list (&resource_list); -if (rc <0 ||IS_ERR (&res)) { +if (rc <0 ) {dev_err (dev,"PMU type %d: No resource address found\n" , type); goto err; } --1.9.1
Signature · 1 line
Tai