staging: dgnc: Add const qualifier to struct declaration.
PATCH 1/1 staging: dgnc: Add const qualifier to struct declaration.
Const qualifier added to struct declaration to make the code more efficient.
--- drivers/staging/dgnc/dgnc_driver.c | 2 +- drivers/staging/dgnc/dgnc_tty.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/dgnc/dgnc_driver.c +1 -1
@@ -93,7 +93,7 @@ struct board_id {unsigned int is_pci_express; }; -static struct board_id dgnc_ids[] = { +static const struct board_id dgnc_ids[] = { {PCI_DEVICE_CLASSIC_4_PCI_NAME ,4 ,0 }, {PCI_DEVICE_CLASSIC_4_422_PCI_NAME ,4 ,0 }, {PCI_DEVICE_CLASSIC_8_PCI_NAME ,8 ,0 },
drivers/staging/dgnc/dgnc_tty.c +1 -1
@@ -50,7 +50,7 @@ static unsigned char *dgnc_TmpWriteBuf;/* * Default transparent print information. */ -static struct digi_t dgnc_digi_init = { +static const struct digi_t dgnc_digi_init = { .digi_flags =DIGI_COOK ,/* Flags */ .digi_maxcps =100 ,/* Max CPS */ .digi_maxchar =50 ,/* Max chars in print queue */
Signature · 1 line
2.7.4
Quoted 2 lines · Elise Lennion
Const qualifier added to struct declaration to make the code more efficient.
It's not an efficiency issue. The goal is to protect the data from being overwritten at runtime.
julia
Quoted 43 lines
Signed-off-by Elise Lennion <[email protected]>--- drivers/staging/dgnc/dgnc_driver.c | 2 +- drivers/staging/dgnc/dgnc_tty.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/staging/dgnc/dgnc_driver.c +1
-1@@ -93,7 +93,7 @@ struct board_id {unsigned int is_pci_express; }; -static struct board_id dgnc_ids[] = { +static const struct board_id dgnc_ids[] = { {PCI_DEVICE_CLASSIC_4_PCI_NAME ,4 ,0 }, {PCI_DEVICE_CLASSIC_4_422_PCI_NAME ,4 ,0 }, {PCI_DEVICE_CLASSIC_8_PCI_NAME ,8 ,0 },drivers/staging/dgnc/dgnc_tty.c +1
-2@@ -50,7 +50,7 @@ static unsigned char *dgnc_TmpWriteBuf;/* * Default transparent print information. */ -static struct digi_t dgnc_digi_init = { +static const struct digi_t dgnc_digi_init = { .digi_flags =DIGI_COOK ,/* Flags */ .digi_maxcps =100 ,/* Max CPS */ .digi_maxchar =50 ,/* Max chars in print queue */ --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161014022116.GA5477%40lennorien.com.
For more options, visit https://groups.google.com/d/optout.