Skip to contentSkip to conversation

power: supply: lp8788: remove an unneeded NULL check

PATCH In review Dan Carpenter 3 participants 3 messages Oct 14, 2016 – Oct 19, 2016

Subsystems (2)
Kernel janitors Power supply
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 power: supply: lp8788: remove an unneeded NULL check

We checked that "pdata->chg_params" is non-NULL earlier in this function so when we add "i" to it, it's still non-NULL.

Signed-off-by Dan Carpenter <[email protected]>
drivers/power/supply/lp8788-charger.c +0 -3
index 7321b72..509e2b3 100644
@@ -384,9 +384,6 @@ static int lp8788_update_charger_params(struct platform_device *pdev,
 	for (i = 0; i < pdata->num_chg_params; i++) {
 		param = pdata->chg_params + i;
 
-		if (!param)
-			continue;
-
 		if (lp8788_is_valid_charger_register(param->addr)) {
 			ret = lp8788_write_byte(lp, param->addr, param->val);
 			if (ret)
maintainer
#2 lore raw
In reply to Dan Carpenter

Hi Dan,

Quoted 10 lines · Dan Carpenter

We checked that "pdata->chg_params" is non-NULL earlier in this function so when we add "i" to it, it's still non-NULL.

Signed-off-by Dan Carpenter <[email protected]>
drivers/power/supply/lp8788-charger.c +0 -0
index 7321b72..509e2b3 100644

drivers/power/supply/lp8788-charger.c static int lp8788_update_charger_params(struct platform_device *pdev, · line 389

Quoted 9 lines
drivers/power/supply/lp8788-charger.c +0 -3
@@ -384,9 +384,6 @@ static int lp8788_update_charger_params(struct platform_device *pdev,
 	for (i = 0; i < pdata->num_chg_params; i++) {
 		param = pdata->chg_params + i;
 
-		if (!param)
-			continue;
-
 		if (lp8788_is_valid_charger_register(param->addr)) {
 			ret = lp8788_write_byte(lp, param->addr, param->val);
 			if (ret)

Thanks, queued.

-- Sebastian