Skip to contentSkip to conversation

drm/i915: Fix cxsr_latency_table reorg

PATCH In review Tvrtko Ursulin 4 participants 4 messages Oct 14, 2016 – Oct 17, 2016

Subsystems (2)
lore
Share & tools
lore

Tvrtko Ursulin

author maintainer
#0 lore raw

PATCH 1/1 drm/i915: Fix cxsr_latency_table reorg

From: Tvrtko Ursulin <[email protected]>

I have re-ordered some struct members in patch:

commit 44a655cae3043453f9dd8076538712d52e2e0ce4
Author: Tvrtko Ursulin <[email protected]>
Date: Thu Oct 13 11:09:23 2016 +0100

drm/i915: Shrink cxsr_latency_table

but that particular one is not initialized with named initializers which broke it.

Move the bitfields back at the beginning. Space saving is still there.

Fixes 44a655cae304 ("drm/i915: Shrink cxsr_latency_table")
Cc Joonas Lahtinen <[email protected]>
Cc Jani Nikula <[email protected]>
---
 drivers/gpu/drm/i915/intel_drv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_drv.h +2 -2
index a885b2ac9618..5bc115496355 100644
@@ -807,14 +807,14 @@ struct intel_watermark_params {
 };
 
 struct cxsr_latency {
+	bool is_desktop : 1;
+	bool is_ddr3 : 1;
 	u16 fsb_freq;
 	u16 mem_freq;
 	u16 display_sr;
 	u16 display_hpll_disable;
 	u16 cursor_sr;
 	u16 cursor_hpll_disable;
-	bool is_desktop : 1;
-	bool is_ddr3 : 1;
 };
 
 #define to_intel_atomic_state(x) container_of(x, struct intel_atomic_state, base)
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: warning for drm/i915: Fix cxsr_latency_table reorg

== Series Details ==

== Series Details ==

Series: drm/i915: Fix cxsr_latency_table reorg
URL : https://patchwork.freedesktop.org/series/13789/
State : warning

== Summary ==

Series 13789v1 drm/i915: Fix cxsr_latency_table reorg
https://patchwork.freedesktop.org/api/1.0/series/13789/revisions/1/mbox/

Test kms_pipe_crc_basic:

        Subgroup read-crc-pipe-b-frame-sequence:
                dmesg-warn -> PASS       (fi-skl-6770hq)
        Subgroup suspend-read-crc-pipe-b:
                pass       -> DMESG-WARN (fi-byt-j1900)
Test vgem_basic:
        Subgroup unload:
                skip       -> PASS       (fi-skl-6700k)
                pass       -> SKIP       (fi-hsw-4770)
                skip       -> PASS       (fi-kbl-7200u)
fi-bdw-5557u     total:246  pass:231  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:246  pass:204  dwarn:0   dfail:0   fail:0   skip:42 
fi-bxt-t5700     total:246  pass:216  dwarn:0   dfail:0   fail:0   skip:30 
fi-byt-j1900     total:246  pass:213  dwarn:1   dfail:0   fail:1   skip:31 
fi-byt-n2820     total:246  pass:210  dwarn:0   dfail:0   fail:1   skip:35 
fi-hsw-4770      total:246  pass:223  dwarn:0   dfail:0   fail:0   skip:23 
fi-hsw-4770r     total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-ilk-650       total:246  pass:184  dwarn:0   dfail:0   fail:2   skip:60 
fi-ivb-3520m     total:246  pass:221  dwarn:0   dfail:0   fail:0   skip:25 
fi-ivb-3770      total:246  pass:221  dwarn:0   dfail:0   fail:0   skip:25 
fi-kbl-7200u     total:246  pass:222  dwarn:0   dfail:0   fail:0   skip:24 
fi-skl-6260u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:246  pass:223  dwarn:0   dfail:0   fail:0   skip:23 
fi-skl-6700k     total:246  pass:221  dwarn:1   dfail:0   fail:0   skip:24 
fi-skl-6770hq    total:246  pass:230  dwarn:1   dfail:0   fail:1   skip:14 
fi-snb-2520m     total:246  pass:210  dwarn:0   dfail:0   fail:0   skip:36 
fi-snb-2600      total:246  pass:209  dwarn:0   dfail:0   fail:0   skip:37 

Results at /archive/results/CI_IGT_test/Patchwork_2723/

e086610ff079f1bf1fe91d4ab175443590cacb8d drm-intel-nightly: 2016y-10m-14d-11h-43m-09s UTC integration manifest a854fc9 drm/i915: Fix cxsr_latency_table reorg

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

Re: ✗ Fi.CI.BAT: warning for drm/i915: Fix cxsr_latency_table reorg

Quoted 8 lines

== Series Details ==

Series: drm/i915: Fix cxsr_latency_table reorg
URL : https://patchwork.freedesktop.org/series/13789/
State : warning

== Summary ==

Quoted 8 lines

Series 13789v1 drm/i915: Fix cxsr_latency_table reorg
https://patchwork.freedesktop.org/api/1.0/series/13789/revisions/1/mbox/

Test kms_pipe_crc_basic:

        Subgroup read-crc-pipe-b-frame-sequence:
                dmesg-warn -> PASS       (fi-skl-6770hq)
        Subgroup suspend-read-crc-pipe-b:
                pass       -> DMESG-WARN (fi-byt-j1900)

https://bugs.freedesktop.org/show_bug.cgi?id=98040

Quoted 24 lines

Test vgem_basic:

        Subgroup unload:
                skip       -> PASS       (fi-skl-6700k)
                pass       -> SKIP       (fi-hsw-4770)
                skip       -> PASS       (fi-kbl-7200u)
fi-bdw-5557u     total:246  pass:231  dwarn:0   dfail:0   fail:0   skip:15
fi-bsw-n3050     total:246  pass:204  dwarn:0   dfail:0   fail:0   skip:42
fi-bxt-t5700     total:246  pass:216  dwarn:0   dfail:0   fail:0   skip:30
fi-byt-j1900     total:246  pass:213  dwarn:1   dfail:0   fail:1   skip:31
fi-byt-n2820     total:246  pass:210  dwarn:0   dfail:0   fail:1   skip:35
fi-hsw-4770      total:246  pass:223  dwarn:0   dfail:0   fail:0   skip:23
fi-hsw-4770r     total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22
fi-ilk-650       total:246  pass:184  dwarn:0   dfail:0   fail:2   skip:60
fi-ivb-3520m     total:246  pass:221  dwarn:0   dfail:0   fail:0   skip:25
fi-ivb-3770      total:246  pass:221  dwarn:0   dfail:0   fail:0   skip:25
fi-kbl-7200u     total:246  pass:222  dwarn:0   dfail:0   fail:0   skip:24
fi-skl-6260u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14
fi-skl-6700hq    total:246  pass:223  dwarn:0   dfail:0   fail:0   skip:23
fi-skl-6700k     total:246  pass:221  dwarn:1   dfail:0   fail:0   skip:24
fi-skl-6770hq    total:246  pass:230  dwarn:1   dfail:0   fail:1   skip:14
fi-snb-2520m     total:246  pass:210  dwarn:0   dfail:0   fail:0   skip:36
fi-snb-2600      total:246  pass:209  dwarn:0   dfail:0   fail:0   skip:37
Quoted 6 lines

Results at /archive/results/CI_IGT_test/Patchwork_2723/

e086610ff079f1bf1fe91d4ab175443590cacb8d drm-intel-nightly: 2016y-10m- 14d-11h-43m-09s UTC integration manifest
a854fc9 drm/i915: Fix cxsr_latency_table reorg

Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Tvrtko Ursulin
Quoted 4 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

I have re-ordered some struct members in patch:

Quoted 9 lines

  commit 44a655cae3043453f9dd8076538712d52e2e0ce4

Quoted 1 line

  Author: Tvrtko Ursulin <[email protected]>

  Date:   Thu Oct 13 11:09:23 2016 +0100

      drm/i915: Shrink cxsr_latency_table

but that particular one is not initialized with named initializers which broke it.

Wrong commit message above this line?

Patch itself is;

Regards, Joonas

Signature · 7 lines
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx