Skip to contentSkip to conversation

stmmac: fix an error code in stmmac_ptp_register()

PATCH In review Dan Carpenter 2 participants 2 messages Oct 14, 2016 – Oct 15, 2016

Subsystems (5)
Networking Network drivers Kernel janitors Arm STM32 +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 stmmac: fix an error code in stmmac_ptp_register()

PTR_ERR(NULL) is success. We have to preserve the error code earlier.

Fixes 7086605a6ab5 ("stmmac: fix error check when init ptp")
Signed-off-by Dan Carpenter <[email protected]>

---
Applies to net.git tree.

drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c +3 -1
index 289d527..5d61fb2 100644
@@ -185,8 +185,10 @@ int stmmac_ptp_register(struct stmmac_priv *priv)
 	priv->ptp_clock = ptp_clock_register(&priv->ptp_clock_ops,
 					     priv->device);
 	if (IS_ERR(priv->ptp_clock)) {
+		int ret = PTR_ERR(priv->ptp_clock);
+
 		priv->ptp_clock = NULL;
-		return PTR_ERR(priv->ptp_clock);
+		return ret;
 	}
 
 	spin_lock_init(&priv->ptp_lock);