Checkpatch.pl error fixed:"Tabstop remove".

PATCH In review Keila Novo 3 participants 6 messages Oct 14, 2016 – Oct 15, 2016

Subsystems (2)

Staging Staging - NVIDIA compliant embedded controller interface (nvec)

lore

Share & tools

lore

Keila Novo

author

2016-10-14 22:12 UTC #0 lore raw

PATCH 1/1 Checkpatch.pl error fixed:"Tabstop remove".

Checkpatch.pl error fixed:"No tabstop at the init
of the line"

Signed-off-by Keila Novo <[email protected]>

---
 drivers/staging/nvec/nvec_power.c | 4 ++++
 1 file changed, 4 insertions(+)

drivers/staging/nvec/nvec_power.c +4 -0

index b16c871..88e6c0e 100644
@@ -441,7 +441,11 @@ static struct platform_driver nvec_power_driver = {
 	.probe = nvec_power_probe,
 	.remove = nvec_power_remove,
 	.driver = {
+<<<<<<< HEAD
 		 .name = "nvec-power",
+=======
+		 .name = nvec_power,
+>>>>>>> 3dedeb1... Checkpatch.pl error fixed:"Tabstop
 	}
 };

Signature · 1 line

2.7.4

Julia Lawall

2016-10-15 07:32 UTC #1 lore raw

Quoted 13 lines · Keila Novo

Checkpatch.pl error fixed:"No tabstop at the init
of the line"
Signed-off-by Keila Novo <[email protected]>
---
 drivers/staging/nvec/nvec_power.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/staging/nvec/nvec_power.c +0 -0
index b16c871..88e6c0e 100644

drivers/staging/nvec/nvec_power.c static struct platform_driver nvec_power_driver = { · line 448

Quoted 8 lines

drivers/staging/nvec/nvec_power.c +4 -0

@@ -441,7 +441,11 @@ static struct platform_driver nvec_power_driver = {
 	.probe = nvec_power_probe,
 	.remove = nvec_power_remove,
 	.driver = {
+<<<<<<< HEAD
 		 .name = "nvec-power",
+=======
+		 .name = nvec_power,
+>>>>>>> 3dedeb1... Checkpatch.pl error fixed:"Tabstop

This is not good.

julia

Quoted 13 lines

drivers/staging/nvec/nvec_power.c +0 -1
 	}
 };
 
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161008055753.GA24115%40kheixx-VB.
For more options, visit https://groups.google.com/d/optout.

Greg Kroah-Hartman

maintainer

2016-10-15 11:28 UTC #2 lore raw

In reply to Keila Novo

Quoted 13 lines · Keila Novo

Checkpatch.pl error fixed:"No tabstop at the init
of the line"
Signed-off-by Keila Novo <[email protected]>
---
 drivers/staging/nvec/nvec_power.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/staging/nvec/nvec_power.c +0 -0
index b16c871..88e6c0e 100644

drivers/staging/nvec/nvec_power.c static struct platform_driver nvec_power_driver = { · line 448

Quoted 8 lines

drivers/staging/nvec/nvec_power.c +4 -0

@@ -441,7 +441,11 @@ static struct platform_driver nvec_power_driver = {
 	.probe = nvec_power_probe,
 	.remove = nvec_power_remove,
 	.driver = {
+<<<<<<< HEAD
 		 .name = "nvec-power",
+=======
+		 .name = nvec_power,
+>>>>>>> 3dedeb1... Checkpatch.pl error fixed:"Tabstop

I don't think you build the code with this patch applied :(

keila novo

author

2016-10-15 13:09 UTC #3 lore raw

Quoted 11 lines · Greg Kroah-Hartman

Review
Quoted 9 lines · Keila Novo
Checkpatch.pl error fixed:"No tabstop at the init
of the line"
Signed-off-by Keila Novo <[email protected]>
---
 drivers/staging/nvec/nvec_power.c | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/drivers/staging/nvec/nvec_power.c

Quoted 6 lines

Quoted 6 lines
index b16c871..88e6c0e 100644
drivers/staging/nvec/nvec_power.c +0 -0
@@ -441,7 +441,11 @@ static struct platform_driver nvec_power_driver = {
      .probe = nvec_power_probe,
      .remove = nvec_power_remove,

Quoted 8 lines

drivers/staging/nvec/nvec_power.c static struct platform_driver nvec_power_driver = { · line 448
Quoted 6 lines
drivers/staging/nvec/nvec_power.c +4 -0
      .driver = {
+<<<<<<< HEAD
               .name = "nvec-power",
+=======
+              .name = nvec_power,
+>>>>>>> 3dedeb1... Checkpatch.pl error fixed:"Tabstop
I don't think you build the code with this patch applied :(

I checked with the checkpatch.pl when I fixed the error and it didn't show any error.
What is my error now?Can you explain it please?

Thanks,

Julia Lawall

2016-10-15 13:13 UTC #4 lore raw

Quoted 29 lines · keila novo

Quoted 11 lines · Greg Kroah-Hartman
Review
Quoted 9 lines · Keila Novo
Checkpatch.pl error fixed:"No tabstop at the init
of the line"
Signed-off-by Keila Novo <[email protected]>
---
drivers/staging/nvec/nvec_power.c | 4 ++++
  1 file changed, 4 insertions(+)
(quoted diff) +0 -0
b/drivers/staging/nvec/nvec_power.c
Quoted 4 lines
drivers/staging/nvec/nvec_power.c static struct platform_driver nvec_power_driver
Quoted 4 lines
index b16c871..88e6c0e 100644
drivers/staging/nvec/nvec_power.c +0 -0
@@ -441,7 +441,11 @@ static struct platform_driver nvec_power_driver
= {
Quoted 9 lines
Quoted 8 lines
drivers/staging/nvec/nvec_power.c +4 -0
        .probe = nvec_power_probe,
        .remove = nvec_power_remove,
        .driver = {
+<<<<<<< HEAD
                 .name = "nvec-power",
+=======
+              .name = nvec_power,
+>>>>>>> 3dedeb1... Checkpatch.pl error fixed:"Tabstop

Quoted 5 lines

Quoted 1 line
I don't think you build the code with this patch applied :(
I checked with the checkpatch.pl when I fixed the error and it didn't show any error.
What is my error now?Can you explain it please?

Your patch, as sent, has git conflict annotations. The <<<< HEAD, etc.

julia

Quoted 14 lines

Thanks,
--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CACrt6MJ_rFuv3APG8%2B Gi-Wef3WhpT-RYv-bkMq0hNbEO8X7D%3DQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

keila novo

author

2016-10-15 13:15 UTC #5 lore raw

Quoted 36 lines · Julia Lawall

Quoted 31 lines · keila novo
Quoted 11 lines · Greg Kroah-Hartman
Review
Quoted 9 lines · Keila Novo
Checkpatch.pl error fixed:"No tabstop at the init
of the line"
Signed-off-by Keila Novo <[email protected]>
---
 drivers/staging/nvec/nvec_power.c | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0
b/drivers/staging/nvec/nvec_power.c
Quoted 4 lines
drivers/staging/nvec/nvec_power.c static struct platform_driver nvec_power_driver
Quoted 4 lines
index b16c871..88e6c0e 100644
drivers/staging/nvec/nvec_power.c +0 -0
@@ -441,7 +441,11 @@ static struct platform_driver nvec_power_driver
= {
Quoted 10 lines
drivers/staging/nvec/nvec_power.c static struct platform_driver nvec_power_driver = { · line 448
Quoted 8 lines
drivers/staging/nvec/nvec_power.c +4 -0
      .probe = nvec_power_probe,
      .remove = nvec_power_remove,
      .driver = {
+<<<<<<< HEAD
               .name = "nvec-power",
+=======
+              .name = nvec_power,
+>>>>>>> 3dedeb1... Checkpatch.pl error fixed:"Tabstop
I don't think you build the code with this patch applied :(

Quoted 13 lines

Quoted 3 lines
I checked with the checkpatch.pl when I fixed the error and it didn't show any error.
What is my error now?Can you explain it please?
Your patch, as sent, has git conflict annotations. The <<<< HEAD, etc.
julia
Quoted 5 lines
Thanks,
--
You received this message because you are subscribed to the Google

Groups

Quoted 2 lines

Quoted 2 lines
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send

Quoted 3 lines

Quoted 3 lines
email to [email protected].
To post to this group, send email to [email protected]. To view this discussion on the web visithttps://

groups.google.com/d/msgid/outreachy-kernel/CACrt6MJ_rFuv3APG8%2B

Quoted 4 lines

Quoted 4 lines
Gi-Wef3WhpT-RYv-bkMq0hNbEO8X7D%3DQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.

Ok, I will fix it.

Thanks for your time