gcc: remove BR2_GCC_NEEDS_MPC
PATCH 1/3 gcc: remove BR2_GCC_NEEDS_MPC
The blind option BR2_GCC_NEEDS_MPC was used to distinguish gcc versions that rely on the mpc library and the ones that don't. But since a while already, all the versions we support do need the mpc library. So this symbol isn't needed anymore.
--- package/gcc/Config.in.host | 8 -------- package/gcc/gcc.mk | 7 ++----- 2 files changed, 2 insertions(+), 13 deletions(-)
package/gcc/Config.in.host +0 -8
@@ -1,8 +1,5 @@ comment "GCC Options" -config BR2_GCC_NEEDS_MPC - bool - config BR2_GCC_SUPPORTS_GRAPHITE bool
@@ -34,7 +31,6 @@ choice depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64el)) # musl mips64 unsupported depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_mips64 || BR2_mips64el)) - select BR2_GCC_NEEDS_MPC select BR2_GCC_SUPPORTS_GRAPHITE select BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
@@ -42,7 +38,6 @@ choice bool "gcc arc (6.x)" # Only supported architecture depends on BR2_arc - select BR2_GCC_NEEDS_MPC select BR2_TOOLCHAIN_GCC_AT_LEAST_6
@@ -63,7 +58,6 @@ choice # musl mips64 unsupported depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_mips64 || BR2_mips64el)) # PR60102 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60102 - select BR2_GCC_NEEDS_MPC select BR2_GCC_SUPPORTS_GRAPHITE select BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
@@ -78,7 +72,6 @@ choice !BR2_mips_m5101 && !BR2_mips_i6400 && !BR2_mips_p6600 # musl mips64 unsupported depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_mips64 || BR2_mips64el)) - select BR2_GCC_NEEDS_MPC select BR2_GCC_SUPPORTS_GRAPHITE select BR2_TOOLCHAIN_GCC_AT_LEAST_5
@@ -88,7 +81,6 @@ choice depends on !BR2_arc # Unsupported MIPS cores depends on !BR2_mips_p6600 - select BR2_GCC_NEEDS_MPC select BR2_GCC_SUPPORTS_GRAPHITE select BR2_TOOLCHAIN_GCC_AT_LEAST_6
package/gcc/gcc.mk +2 -5
@@ -82,6 +82,7 @@ endef HOST_GCC_COMMON_DEPENDENCIES = \ host-binutils \ host-gmp \ + host-mpc \ host-mpfr \ $(if $(BR2_BINFMT_FLAT),host-elf2flt)
@@ -93,6 +94,7 @@ HOST_GCC_COMMON_CONF_OPTS = \ --disable-libssp \ --disable-multilib \ --with-gmp=$(HOST_DIR)/usr \ + --with-mpc=$(HOST_DIR)/usr \ --with-mpfr=$(HOST_DIR)/usr \ --with-pkgversion="Buildroot $(BR2_VERSION_FULL)" \ --with-bugurl="http://bugs.buildroot.net/"
@@ -161,11 +163,6 @@ else HOST_GCC_COMMON_CONF_OPTS += --enable-threads endif -ifeq ($(BR2_GCC_NEEDS_MPC),y) -HOST_GCC_COMMON_DEPENDENCIES += host-mpc -HOST_GCC_COMMON_CONF_OPTS += --with-mpc=$(HOST_DIR)/usr -endif - ifeq ($(BR2_GCC_ENABLE_GRAPHITE),y) HOST_GCC_COMMON_DEPENDENCIES += host-isl HOST_GCC_COMMON_CONF_OPTS += --with-isl=$(HOST_DIR)/usr
Signature · 1 line
2.9.3
PATCH 2/3 gcc: gcc arc supports graphite
The ARC version of gcc does support graphite. It was probably just forgotten when the BR2_GCC_VERSION_ARC symbol was introduced.
While we're at it, also remove a redundant newline.
---
Please await confirmation from the ARC Maintainers before committing.
--- package/gcc/Config.in.host | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/gcc/Config.in.host +1 -1
@@ -38,9 +38,9 @@ choice bool "gcc arc (6.x)" # Only supported architecture depends on BR2_arc + select BR2_GCC_SUPPORTS_GRAPHITE select BR2_TOOLCHAIN_GCC_AT_LEAST_6 - config BR2_GCC_VERSION_4_9_X bool "gcc 4.9.x" # Broken or unsupported architectures
Signature · 1 line
2.9.3
PATCH 3/3 gcc: remove BR2_GCC_SUPPORTS_GRAPHITE
In reply to Arnout Vandecappelle (Essensium/Mind)The blind option BR2_GCC_SUPPORTS_GRAPHITE was used to distinguish gcc versions that support the graphite loop optimizer. But since a while already, all the versions we support do support graphite. So this symbol isn't needed anymore.
--- package/gcc/Config.in.host | 9 --------- 1 file changed, 9 deletions(-)
package/gcc/Config.in.host +0 -9
@@ -1,8 +1,5 @@ comment "GCC Options" -config BR2_GCC_SUPPORTS_GRAPHITE - bool - choice prompt "GCC compiler Version" default BR2_GCC_VERSION_ARC if BR2_arc
@@ -31,14 +28,12 @@ choice depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64el)) # musl mips64 unsupported depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_mips64 || BR2_mips64el)) - select BR2_GCC_SUPPORTS_GRAPHITE select BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 config BR2_GCC_VERSION_ARC bool "gcc arc (6.x)" # Only supported architecture depends on BR2_arc - select BR2_GCC_SUPPORTS_GRAPHITE select BR2_TOOLCHAIN_GCC_AT_LEAST_6 config BR2_GCC_VERSION_4_9_X
@@ -58,7 +53,6 @@ choice # musl mips64 unsupported depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_mips64 || BR2_mips64el)) # PR60102 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60102 - select BR2_GCC_SUPPORTS_GRAPHITE select BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 config BR2_GCC_VERSION_5_X
@@ -72,7 +66,6 @@ choice !BR2_mips_m5101 && !BR2_mips_i6400 && !BR2_mips_p6600 # musl mips64 unsupported depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_mips64 || BR2_mips64el)) - select BR2_GCC_SUPPORTS_GRAPHITE select BR2_TOOLCHAIN_GCC_AT_LEAST_5 config BR2_GCC_VERSION_6_X
@@ -81,7 +74,6 @@ choice depends on !BR2_arc # Unsupported MIPS cores depends on !BR2_mips_p6600 - select BR2_GCC_SUPPORTS_GRAPHITE select BR2_TOOLCHAIN_GCC_AT_LEAST_6 endchoice
@@ -167,7 +159,6 @@ config BR2_GCC_ENABLE_LIBMUDFLAP config BR2_GCC_ENABLE_GRAPHITE bool "Enable graphite support" - depends on BR2_GCC_SUPPORTS_GRAPHITE help This option enables the graphite optimizations in the compiler.
Signature · 1 line
2.9.3
PATCH 1/3 gcc: remove BR2_GCC_NEEDS_MPC
In reply to Arnout Vandecappelle (Essensium/Mind)Hello,
Quoted 10 lines · Arnout Vandecappelle (Essensium/Mind)
The blind option
BR2_GCC_NEEDS_MPCwas used to distinguish gcc versions that rely on the mpc library and the ones that don't. But since a while already, all the versions we support do need the mpc library. So this symbol isn't needed anymore.--- package/gcc/Config.in.host | 8 -------- package/gcc/gcc.mk | 7 ++----- 2 files changed, 2 insertions(+), 13 deletions(-)
All applied, thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com