staging: xgifb: Compress return logic into one line.

PATCH New Elise Lennion 1 participant 1 message Oct 17, 2016 Staging

lore

Share & tools

lore

Elise Lennion

author

2016-10-17 02:17 UTC #0 lore raw

PATCH 2/3 staging: xgifb: Compress return logic into one line.

Simplify return logic to avoid unnecessary variable assignments.

Coccinelle was used with this semantic patch:
@@
local idexpression ret;
expression e;
@@

-ret =
+return

e;

-return ret;

Signed-off-by Elise Lennion <[email protected]>

---
 drivers/staging/xgifb/vb_setmode.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

drivers/staging/xgifb/vb_setmode.c +3 -6

index d8010c5..f4bcb156 100644
@@ -1682,13 +1682,11 @@ static unsigned char XGI_GetVCLKPtr(unsigned short RefreshRateTableIndex,
 			}
 
 			if (pVBInfo->TVInfo & TVSetYPbPr750p) {
-				tempal = XGI_YPbPr750pVCLK;
-				return tempal;
+				return XGI_YPbPr750pVCLK;
 			}
 
 			if (pVBInfo->TVInfo & TVSetYPbPr525p) {
-				tempal = YPbPr525pVCLK;
-				return tempal;
+				return YPbPr525pVCLK;
 			}
 
 			tempal = NTSC1024VCLK;

@@ -1705,8 +1703,7 @@ static unsigned char XGI_GetVCLKPtr(unsigned short RefreshRateTableIndex,
 	} /* {End of VB} */
 
 	inb((pVBInfo->P3ca + 0x02));
-	tempal = XGI330_RefIndex[RefreshRateTableIndex].Ext_CRTVCLK;
-	return tempal;
+	return XGI330_RefIndex[RefreshRateTableIndex].Ext_CRTVCLK;
 }
 
 static void XGI_GetVCLKLen(unsigned char tempal, unsigned char *di_0,

Signature · 1 line

2.7.4