staging: lov.ko: lov_object.c: fix sparse warning setting function to static
PATCH 1/1 staging: lov.ko: lov_object.c: fix sparse warning setting function to static
Fixed: sparse WARNING: symbol 'lov_read_and_clear_async_rc' was not declared. Should it be static?
--- drivers/staging/lustre/lustre/lov/lov_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/lov/lov_object.c +1 -1
@@ -1532,7 +1532,7 @@ struct lov_stripe_md *lov_lsm_addref(struct lov_object *lov)return lsm; } -int lov_read_and_clear_async_rc (struct cl_object *clob) +static int lov_read_and_clear_async_rc (struct cl_object *clob) {struct lu_object *luobj;int rc =0 ;
Signature · 1 line
2.7.4
Greg KH
maintainerPATCH 1/1 staging: lov.ko: lov_object.c: fix sparse warning setting function to static
Quoted 1 line · Ryan Swan
Fixed: sparse WARNING: symbol '
lov_read_and_clear_async_rc' was not declared. Should it be static?
I don't believe you actually test-built this change :(
Quoted 11 lines
Signed-off-by Ryan Swan <[email protected]>--- drivers/staging/lustre/lustre/lov/lov_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/lustre/lustre/lov/lov_object.c +0
-0
drivers/staging/lustre/lustre/lov/lov_object.c struct lov_stripe_md *lov_lsm_addref(struct lov_object *lov) · line 1535
Quoted 5 lines
drivers/staging/lustre/lustre/lov/lov_object.c +1
-1@@ -1532,7 +1532,7 @@ struct lov_stripe_md *lov_lsm_addref(struct lov_object *lov)return lsm; } -int lov_read_and_clear_async_rc (struct cl_object *clob) +static int lov_read_and_clear_async_rc (struct cl_object *clob)
You are turning a symbol that is explicitly exported into a static one? How is the compiler supposed to figure out what to do when you do that?
Again, always test-build your patches so you don't get a grumpy maintainer telling you to test-build your patches...
greg k-h