Skip to contentSkip to conversation

staging: vt6656: Remove unnecessary parentheses.

PATCH In review Elise Lennion 1 participant 1 message Oct 18, 2016 Staging

lore
Share & tools
lore

Elise Lennion

author
#0 lore raw

PATCH 3/3 staging: vt6656: Remove unnecessary parentheses.

The removed parentheses are unnecessary and don't add readability.

Found using Coccinelle semantic patch:
@@ expression e, e1, e2; @@
e +=
(

        (e1 == e2)

|
- (e1)
+ e1
)

@@ expression e, e1, e2; @@
e =
(

        (e1 == e2)

|
- (e1)
+ e1
)

Signed-off-by Elise Lennion <[email protected]>
---
 drivers/staging/vt6656/mac.c | 2 +-
 drivers/staging/vt6656/rf.c  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/vt6656/mac.c +1 -1
index eeed16e..611da49 100644
@@ -121,7 +121,7 @@ void vnt_mac_set_keyentry(struct vnt_private *priv, u16 key_ctl, u32 entry_idx,
 	u16 offset;
 
 	offset = MISCFIFO_KEYETRY0;
-	offset += (entry_idx * MISCFIFO_KEYENTRYSIZE);
+	offset += entry_idx * MISCFIFO_KEYENTRYSIZE;
 
 	set_key.u.write.key_ctl = cpu_to_le16(key_ctl);
 	ether_addr_copy(set_key.u.write.addr, addr);
drivers/staging/vt6656/rf.c +2 -2
index 79a3108..8b72479 100644
@@ -800,8 +800,8 @@ int vnt_rf_set_txpower(struct vnt_private *priv, u8 power, u32 rate)
 /* Convert rssi to dbm */
 void vnt_rf_rssi_to_dbm(struct vnt_private *priv, u8 rssi, long *dbm)
 {
-	u8 idx = (((rssi & 0xc0) >> 6) & 0x03);
-	long b = (rssi & 0x3f);
+	u8 idx = ((rssi & 0xc0) >> 6) & 0x03;
+	long b = rssi & 0x3f;
 	long a = 0;
 	u8 airoharf[4] = {0, 18, 0, 40};
Signature · 1 line
2.7.4