Skip to contentSkip to conversation

ASoC: sst-bxt-da7219_max98357a: fix obsoleted initializer for array

PATCH In review Colin King 4 participants 4 messages Oct 17, 2016 – Oct 24, 2016

Subsystems (3)
lore
Share & tools
lore

Colin King

author
#0 lore raw

PATCH 1/1 ASoC: sst-bxt-da7219_max98357a: fix obsoleted initializer for array

From: Colin Ian King <[email protected]>

Smatch reports below warnings:

bxt_da7219_max98357a.c:352:9: warning: obsolete array initializer, use C99 syntax

An earlier commit cleaned up similar warnings, however, a recent commit 43c02ede76a60de ("ASoC: Intel: Add DMIC channel constraint for bxt machine") re-introduced the older initializer style. So fix this warning to make the code consistent.

---
 sound/soc/intel/boards/bxt_da7219_max98357a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/boards/bxt_da7219_max98357a.c +1 -1
index 865a21e..bff80b4 100644
@@ -348,7 +348,7 @@ static struct snd_soc_dai_link broxton_dais[] = {
 		.dynamic = 1,
 		.ops = &broxton_refcap_ops,
 	},
-	[BXT_DPCM_AUDIO_DMIC_CP]
+	[BXT_DPCM_AUDIO_DMIC_CP] =
 	{
 		.name = "Bxt Audio DMIC cap",
 		.stream_name = "dmiccap",
Signature · 1 line
2.9.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Colin King

From: Colin Ian King <[email protected]>

Smatch reports below warnings:

bxt_da7219_max98357a.c:352:9: warning: obsolete array initializer, use C99 syntax

An earlier commit cleaned up similar warnings, however, a recent commit 43c02ede76a60de ("ASoC: Intel: Add DMIC channel constraint for bxt machine") re-introduced the older initializer style. So fix this warning to make the code consistent.

Quoted 4 lines
---
 sound/soc/intel/boards/bxt_da7219_max98357a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

sound/soc/intel/boards/bxt_da7219_max98357a.c static struct snd_soc_dai_link broxton_dais[] = { · line 354

Quoted 13 lines
sound/soc/intel/boards/bxt_da7219_max98357a.c +1 -1
index 865a21e..bff80b4 100644
@@ -348,7 +348,7 @@ static struct snd_soc_dai_link broxton_dais[] = {
 		.dynamic = 1,
 		.ops = &broxton_refcap_ops,
 	},
-	[BXT_DPCM_AUDIO_DMIC_CP]
+	[BXT_DPCM_AUDIO_DMIC_CP] =
 	{
 		.name = "Bxt Audio DMIC cap",
 		.stream_name = "dmiccap",

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Acked-by on v1 1/1
#2 lore raw
In reply to Colin King
Quoted 11 lines · Colin King

From: Colin Ian King <[email protected]>

Smatch reports below warnings:

bxt_da7219_max98357a.c:352:9: warning: obsolete array initializer, use C99 syntax

An earlier commit cleaned up similar warnings, however, a recent commit 43c02ede76a60de ("ASoC: Intel: Add DMIC channel constraint for bxt machine") re-introduced the older initializer style. So fix this warning to make the code consistent.

Signature · 1 line
~Vinod
maintainer
#3 lore raw

Applied "ASoC: sst-bxt-da7219_max98357a: fix obsoleted initializer for array" to the asoc tree

In reply to Colin King

The patch

ASoC: sst-bxt-da7219_max98357a: fix obsoleted initializer for array

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 89c03ddbb9aafe370e7d1ebe07258ae755588bdc Mon Sep 17 00:00:00 2001

From: Colin Ian King <[email protected]>
Date: Mon, 17 Oct 2016 23:02:56 +0100
Subject: [PATCH] ASoC: sst-bxt-da7219_max98357a: fix obsoleted initializer for
array

Smatch reports below warnings:

bxt_da7219_max98357a.c:352:9: warning: obsolete array initializer, use C99 syntax

An earlier commit cleaned up similar warnings, however, a recent commit 43c02ede76a60de ("ASoC: Intel: Add DMIC channel constraint for bxt machine") re-introduced the older initializer style. So fix this warning to make the code consistent.

---
 sound/soc/intel/boards/bxt_da7219_max98357a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/boards/bxt_da7219_max98357a.c +1 -1
index 865a21e557cc..bff80b467262 100644
@@ -348,7 +348,7 @@ static struct snd_soc_dai_link broxton_dais[] = {
 		.dynamic = 1,
 		.ops = &broxton_refcap_ops,
 	},
-	[BXT_DPCM_AUDIO_DMIC_CP]
+	[BXT_DPCM_AUDIO_DMIC_CP] =
 	{
 		.name = "Bxt Audio DMIC cap",
 		.stream_name = "dmiccap",
Signature · 1 line
2.8.1