Skip to contentSkip to conversation

qt5base: fix misspelling of "directfb"

PATCH New Matt Kraai 2 participants 4 messages Oct 18, 2016

lore
Share & tools
lore

Matt Kraai

author
#0 lore raw

PATCH 1/1 qt5base: fix misspelling of "directfb"

---
 package/qt5/qt5base/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/qt5/qt5base/Config.in +1 -1
index 64a7f65..6933523 100644
@@ -180,7 +180,7 @@ config BR2_PACKAGE_QT5BASE_DIRECTFB
 	bool "directfb support"
 	depends on BR2_PACKAGE_DIRECTFB
 
-comment "directfb backend if directb is enabled"
+comment "directfb backend if directfb is enabled"
 	depends on !BR2_PACKAGE_DIRECTFB
 
 config BR2_PACKAGE_QT5BASE_XCB
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 qt5base: fix misspelling of "directfb"

Hello,

package/qt5/qt5base/Config.in config BR2_PACKAGE_QT5BASE_DIRECTFB · line 184

Quoted 3 lines · Matt Kraai
package/qt5/qt5base/Config.in +1 -1
-comment "directfb backend if directb is enabled"
+comment "directfb backend if directfb is enabled"
 	depends on !BR2_PACKAGE_DIRECTFB

Thanks, but this sentence in fact doesn't make a lot of sense. It should be something like:

directfb backend needs directfb to be enabled

Or perhaps no comment at all because it's completely obvious that to use DirectFB functionality, you need DirectFB.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 qt5base: fix misspelling of "directfb"

Hi,

Quoted 9 lines · Thomas Petazzoni

package/qt5/qt5base/Config.in config BR2_PACKAGE_QT5BASE_DIRECTFB · line 184

Quoted 3 lines · Matt Kraai
package/qt5/qt5base/Config.in +1 -1
-comment "directfb backend if directb is enabled"
+comment "directfb backend if directfb is enabled"
 	depends on !BR2_PACKAGE_DIRECTFB

Thanks, but this sentence in fact doesn't make a lot of sense. It should be something like:

Quoted 4 lines

directfb backend needs directfb to be enabled

Or perhaps no comment at all because it's completely obvious that to use DirectFB functionality, you need DirectFB.

If the comment is removed, then there is no indication that a directfb backend is available if directfb is disabled. That's inconsistent with the handling of the other backends, which have the following comments if they're not available:

* X.org XCB backend available if X.org is enabled
* eglfs backend available if OpenGL and EGL are enabled

Should I still remove the comment? Or make the message consistent with the other backends (i.e., "directfb backend available if directfb is enabled")?

Signature · 1 line
Matt                                           https://ftbfs.org/~kraai/
#3 lore raw

PATCH 1/1 qt5base: fix misspelling of "directfb"

Hello,

Quoted 7 lines · Matt Kraai

If the comment is removed, then there is no indication that a directfb backend is available if directfb is disabled. That's inconsistent with the handling of the other backends, which have the following comments if they're not available:

* X.org XCB backend available if X.org is enabled
* eglfs backend available if OpenGL and EGL are enabled

Indeed.

Quoted 3 lines

Should I still remove the comment? Or make the message consistent with the other backends (i.e., "directfb backend available if directfb is enabled")?

Let's keep the comment, just adjusted.

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com