Skip to contentSkip to conversation

nvmet-rdma: Fix REJ status code

PATCH New Bart Van Assche 3 participants 3 messages Oct 18, 2016 – Oct 20, 2016

Subsystems (2)
NVMe NVMe target
lore
Share & tools
lore

Bart Van Assche

author
#0 lore raw

PATCH 1/1 nvmet-rdma: Fix REJ status code

nvmet_sq_init() returns a value <= 0. nvmet_rdma_cm_reject() expects a second argument that is a NVME_RDMA_CM_* constant. Hence this patch.

Signed-off-by Bart Van Assche <bart.vanassche at sandisk.com>
---
 drivers/nvme/target/rdma.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/nvme/target/rdma.c +4 -1
index f8d2399..35b97a8 100644
@@ -1044,8 +1044,10 @@ nvmet_rdma_alloc_queue(struct nvmet_rdma_device *ndev,
 	}
 
 	ret = nvmet_sq_init(&queue->nvme_sq);
-	if (ret)
+	if (ret) {
+		ret = NVME_RDMA_CM_NO_RSC;
 		goto out_free_queue;
+	}
 
 	ret = nvmet_rdma_parse_cm_connect_req(&event->param.conn, queue);
 	if (ret)

@@ -1114,6 +1116,7 @@ nvmet_rdma_alloc_queue(struct nvmet_rdma_device *ndev,
 out_free_queue:
 	kfree(queue);
 out_reject:
+	pr_debug("rejecting connect request with status code %d\n", ret);
 	nvmet_rdma_cm_reject(cm_id, ret);
 	return NULL;
 }
Signature · 1 line
2.10.1
maintainer
#1 lore raw

PATCH 1/1 nvmet-rdma: Fix REJ status code

Quoted 4 lines · Bart Van Assche

nvmet_sq_init() returns a value <= 0. nvmet_rdma_cm_reject() expects a second argument that is a NVME_RDMA_CM_* constant. Hence this patch.

Signed-off-by Bart Van Assche <bart.vanassche at sandisk.com>

Looks fine,

Reviewed-by Christoph Hellwig <hch at lst.de>