Skip to contentSkip to conversation

DLM: Don't specify WQ_UNBOUND for the ast callback workqueue

PATCH New Bob Peterson 2 participants 2 messages Oct 19, 2016 1 message not in the archive Distributed lock manager (DLM)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Bob Peterson

author
#1 lore raw

PATCH 1/1 DLM: Don't specify WQ_UNBOUND for the ast callback workqueue

Hi,

This patch removes the WQ_UNBOUND flag (which implies WQ_HIGHPRI) from the DLM's ast work queue, in favor of just WQ_HIGHPRI. This has been shown to cause a 19 percent performance increase for simultaneous inode creates on GFS2 with fs_mark.

Signed-off-by Bob Peterson <[email protected]>

---

fs/dlm/ast.c +1 -1
index dcea1e3..07fed83 100644
@@ -268,7 +268,7 @@ void dlm_callback_work(struct work_struct *work)
 int dlm_callback_start(struct dlm_ls *ls)
 {
 	ls->ls_callback_wq = alloc_workqueue("dlm_callback",
-					     WQ_UNBOUND | WQ_MEM_RECLAIM, 0);
+					     WQ_HIGHPRI | WQ_MEM_RECLAIM, 0);
 	if (!ls->ls_callback_wq) {
 		log_print("can't start dlm_callback workqueue");
 		return -ENOMEM;
maintainer
#2 lore raw

PATCH 1/1 DLM: Don't specify WQ_UNBOUND for the ast callback workqueue

Quoted 6 lines · Bob Peterson

Hi,

This patch removes the WQ_UNBOUND flag (which implies WQ_HIGHPRI) from the DLM's ast work queue, in favor of just WQ_HIGHPRI. This has been shown to cause a 19 percent performance increase for simultaneous inode creates on GFS2 with fs_mark.

I've pushed this and the other two to the next branch.