Skip to contentSkip to conversation

liburcu: needs MMU

PATCH New Baruch Siach 2 participants 2 messages Oct 19, 2016

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 liburcu: needs MMU

The test_urcu_fork.c test calls fork(). Upstream provides no easy way to disable tests build.

Fixes:
http://autobuild.buildroot.net/results/9eb/9eb182ab2d0b396eeff3d637a040da5a4d5bdcd7/
http://autobuild.buildroot.net/results/47a/47aabc219a2fd50105881b1e2715f7eeb1a6a588/
http://autobuild.buildroot.net/results/566/56631605f76b8623c9674f25c529ac67d0de12a8/

---
v2: move MMU dependency to BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS (ThomasP)

---
 package/liburcu/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/liburcu/Config.in +1 -0
index 49510da4956c..b5b632687851 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	bool
 	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_USE_MMU # fork() in test
 	default y
 
 config BR2_PACKAGE_LIBURCU
Signature · 1 line
2.9.3
#1 lore raw

PATCH v2 1/1 liburcu: needs MMU

Hello,

Quoted 8 lines · Baruch Siach

The test_urcu_fork.c test calls fork(). Upstream provides no easy way to disable tests build.

Fixes:
http://autobuild.buildroot.net/results/9eb/9eb182ab2d0b396eeff3d637a040da5a4d5bdcd7/
http://autobuild.buildroot.net/results/47a/47aabc219a2fd50105881b1e2715f7eeb1a6a588/
http://autobuild.buildroot.net/results/566/56631605f76b8623c9674f25c529ac67d0de12a8/

Quoted 6 lines

---
v2: move MMU dependency to BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS (ThomasP)

---
 package/liburcu/Config.in | 1 +
 1 file changed, 1 insertion(+)

Applied to master, thanks. However, it would be good if you could report the issue upstream. It's indeed rather annoying that only for their tests we have to disable this package on no-MMU platform. Not annoying enough to have us spend time on this, but annoying enough to report it upstream IMO.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com