Skip to contentSkip to conversation

x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK

PATCH In review Alexander Kuleshov 3 participants 4 messages Oct 19, 2016 – Oct 20, 2016

Subsystems (2)
x86 x86 entry code
lore
Share & tools
lore

Alexander Kuleshov

author
#0 lore raw

PATCH 1/1 x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK

as no-one user of ALLOC_PT_GPREGS_ON_STACK macro doesn't pass it.

Signed-off-by Alexander Kuleshov <[email protected]>
---
 arch/x86/entry/calling.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/entry/calling.h +2 -2
index 9a9e588..b493c6a 100644
@@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with
 
 #define SIZEOF_PTREGS	21*8
 
-	.macro ALLOC_PT_GPREGS_ON_STACK addskip=0
-	addq	$-(15*8+\addskip), %rsp
+	.macro ALLOC_PT_GPREGS_ON_STACK
+	addq	$-(15*8), %rsp
 	.endm
 
 	.macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
Signature · 1 line
2.8.0.rc3.1353.gea9bdc0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Alexander Kuleshov

as no-one user of ALLOC_PT_GPREGS_ON_STACK macro doesn't pass it.

Signed-off-by Alexander Kuleshov <[email protected]>
---
 arch/x86/entry/calling.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/entry/calling.h +0 -0
index 9a9e588..b493c6a 100644

arch/x86/entry/calling.h For 32-bit we have the following conventions - kernel is built with · line 97

Quoted 10 lines
arch/x86/entry/calling.h +2 -2
@@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with
 
 #define SIZEOF_PTREGS	21*8
 
-	.macro ALLOC_PT_GPREGS_ON_STACK addskip=0
-	addq	$-(15*8+\addskip), %rsp
+	.macro ALLOC_PT_GPREGS_ON_STACK
+	addq	$-(15*8), %rsp
 	.endm
 
 	.macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
Reviewed-by Borislav Petkov <[email protected]>
Signature · 4 lines
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
merge bot
#2 lore raw

[tip:x86/urgent] x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK

In reply to Alexander Kuleshov
x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK
Commit-ID:  ac679bf247cf044a5be6ca7d380307540284dd45
Gitweb:     http://git.kernel.org/tip/ac679bf247cf044a5be6ca7d380307540284dd45
Author:     Alexander Kuleshov <[email protected]>
AuthorDate: Thu, 20 Oct 2016 01:11:08 +0600
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Thu, 20 Oct 2016 10:57:37 +0200

x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK

The ALLOC_PT_GPREGS_ON_STACK macro has an optional addskip parameter, which is not used by any usage site. Remove it.

Signed-off-by Alexander Kuleshov <[email protected]>
Reviewed-by Borislav Petkov <[email protected]>
Cc Paolo Bonzini <[email protected]>
Cc Andy Lutomirski <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Thomas Gleixner <[email protected]>
---
 arch/x86/entry/calling.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/entry/calling.h +2 -2
index 9a9e588..b493c6a 100644
@@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with
 
 #define SIZEOF_PTREGS	21*8
 
-	.macro ALLOC_PT_GPREGS_ON_STACK addskip=0
-	addq	$-(15*8+\addskip), %rsp
+	.macro ALLOC_PT_GPREGS_ON_STACK
+	addq	$-(15*8), %rsp
 	.endm
 
 	.macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
merge bot
#3 lore raw

[tip:x86/asm] x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro

In reply to Alexander Kuleshov
x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro
Commit-ID:  59df2268311795ee7161776248d5288ee0841d41
Gitweb:     http://git.kernel.org/tip/59df2268311795ee7161776248d5288ee0841d41
Author:     Alexander Kuleshov <[email protected]>
AuthorDate: Thu, 20 Oct 2016 01:11:08 +0600
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 20 Oct 2016 08:42:36 +0200

x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro

Signed-off-by Alexander Kuleshov <[email protected]>
Reviewed-by Borislav Petkov <[email protected]>
Cc Andy Lutomirski <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc Brian Gerst <[email protected]>
Cc Denys Vlasenko <[email protected]>
Cc H. Peter Anvin <[email protected]>
Cc Josh Poimboeuf <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Paolo Bonzini <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Thomas Gleixner <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Ingo Molnar <[email protected]>
---
 arch/x86/entry/calling.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/entry/calling.h +2 -2
index 9a9e588..b493c6a 100644
@@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with
 
 #define SIZEOF_PTREGS	21*8
 
-	.macro ALLOC_PT_GPREGS_ON_STACK addskip=0
-	addq	$-(15*8+\addskip), %rsp
+	.macro ALLOC_PT_GPREGS_ON_STACK
+	addq	$-(15*8), %rsp
 	.endm
 
 	.macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1