Skip to contentSkip to conversation

Remove verbose msg() from send_push_reply()

PATCH In review Steffan Karger 2 participants 2 messages Oct 19, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove verbose msg() from send_push_reply()

Probably committed by lev by accident, and then overlooked by me during review.

---
 src/openvpn/push.c | 2 --
 1 file changed, 2 deletions(-)
src/openvpn/push.c +0 -2
index ff374c8..54726e7 100644
@@ -431,8 +431,6 @@ send_push_reply (struct context *c, struct push_list *per_client_push_list)
   const int safe_cap = BCAP (&buf) - extra;
   bool push_sent = false;
 
-  msg( M_INFO, "send_push_reply(): safe_cap=%d", safe_cap );
-
   buf_printf (&buf, "%s", push_reply_cmd);
 
   /* send options which are common to all clients */
Signature · 1 line
2.7.4
#1 lore raw

ACK. Not Lev to blaim, I put that debug there - back in the "how do I get ifconfig-ipv6 into that buffer?" times :-) - but it definitely makes sense to kick it.

Your patch has been applied to the master branch - it would make sense to remove that in release/2.3 as well, but the surrounding code is different enough that "just cherrypicking" fails and I'm lazy.

commit f3145272584ac60e061ade0325bb72bada674957 (master)

Author: Steffan Karger
Date:   Wed Oct 19 21:03:27 2016 +0200
     Remove verbose msg() from send_push_reply()

     Signed-off-by: Steffan Karger <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: http://www.mail-archive.com/search?l=mid&[email protected]...
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering