Skip to contentSkip to conversation

i915 and GTV-g maintenance, workflows and CI

DISCUSSION Jani Nikula 4 participants 6 messages Oct 20, 2016

lore
Share & tools
lore
#0 lore raw

We need to formalize the process between i915 proper and GVT-g a bit more, and address some of the current shortcomings and issues in the process and GVT-g CI.

This started off internally as a random list of items, I'm including some of the current status as well. Please comment, as some of the stuff here are just my opinions.

* How do we ensure GVT-g patches get the same kind of pre-merge CI coverage as we have for other i915 code? Could we at least make CI run tests on GVT-g pull requests before merging to drm-intel trees?

=> Work in progress to set up GVT-g CI.

* How do we handle fixes to GVT-g code? Do all fixes need to go via the GVT-g mailing lists and review? We're bound to get GVT-g patches on intel-gfx mailing list too. There's confusion already [1]. Mostly the GVT-g changes come from GVT-g maintainers as pull requests.

[1] https://patchwork.freedesktop.org/series/14000/

* GVT-g related changes to i915 proper must be reviewed on intel-gfx mailing list, and must either be applied to drm-intel directly, or get an ack to be merged via GVT-g tree and pull requests.

* GVT-g needs to start annotating fixes with the Fixes: tags, preferably also cc: stable when we get that far, so our fixes plumbing can figure out which commits to backport.

=> GVT-g maintainers will take care of this.

* Should GVT-g have a MAINTAINERS entry of its own?

=> https://github.com/01org/gvt-linux/commit/41161c9e9e50a5bad98a0e74ad0878c352bdea40

+INTEL GVT-g DRIVERS (Intel GPU Virtualization)
+M: Zhenyu Wang <[email protected]>
+M: Zhi Wang <[email protected]>
+L: [email protected]
+L: [email protected]
+W: https://01.org/igvt-g
+T: git https://github.com/01org/gvt-linux.git
+S: Supported
+F: drivers/gpu/drm/i915/gvt/

I think we'll want to keep intel-gfx there, but mostly I think it's fine for the usual GVT-g development to happen on igvt-g-dev only.

* [email protected] needs to start accepting mails from non-subscribers.

=> Work in progress.

* GVT-g needs to start paying more attention to compiler and sparse warnings.

=> GVT-G maintainers will take care of this.

* GVT-g could use some overview documentation under Documentation/gpu.

* GVT-g bug management. Do you have something set up already? Would be great to be able to use https://bugs.freedesktop.org so we could reassign between i915 and GVT-g.

What did I forget/overlook?

BR,
Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 9 lines · Jani Nikula

We need to formalize the process between i915 proper and GVT-g a bit more, and address some of the current shortcomings and issues in the process and GVT-g CI.

This started off internally as a random list of items, I'm including some of the current status as well. Please comment, as some of the stuff here are just my opinions.

Quoted 5 lines

* How do we ensure GVT-g patches get the same kind of pre-merge CI coverage as we have for other i915 code? Could we at least make CI run tests on GVT-g pull requests before merging to drm-intel trees?

=> Work in progress to set up GVT-g CI.

Personally I don't think gvt needs to pass drm-intel CI. If GVT folks want to do that then it's fine, but otherwise I'm leaning towards treating gvt like a sub-driver, with its own flavour of testing and review standards.

Of course anything touching shared code (i.e. outside of the gvt/ subdir), or code which can't be disabled with Kconfig needs to follow our established review&testing procedures. So submission to intel-gfx, CI by patchwork, review per our standards.

Quoted 6 lines

* How do we handle fixes to GVT-g code? Do all fixes need to go via the GVT-g mailing lists and review? We're bound to get GVT-g patches on intel-gfx mailing list too. There's confusion already [1]. Mostly the GVT-g changes come from GVT-g maintainers as pull requests.

[1] https://patchwork.freedesktop.org/series/14000/

Atm the gvt mailing list is closed, and there's no maintainer entry for it either. I think Zhenyu just needs to hang out here on intel-gfx to catch these, and then pick any gvt/ fixes up himself.

Quoted 3 lines

* GVT-g related changes to i915 proper must be reviewed on intel-gfx mailing list, and must either be applied to drm-intel directly, or get an ack to be merged via GVT-g tree and pull requests.

Ack.

Quoted 5 lines

* GVT-g needs to start annotating fixes with the Fixes: tags, preferably also cc: stable when we get that far, so our fixes plumbing can figure out which commits to backport.

=> GVT-g maintainers will take care of this.

Either that, or they need to send -fixes pull requests your way. I think we could try out either approach, but yes in the end gvt maintainers need to own this. We (i915 team here) won't take care of that.

Quoted 8 lines

* Should GVT-g have a MAINTAINERS entry of its own?

=> https://github.com/01org/gvt-linux/commit/41161c9e9e50a5bad98a0e74ad0878c352bdea40

+INTEL GVT-g DRIVERS (Intel GPU Virtualization)
+M: Zhenyu Wang <[email protected]>
+M: Zhi Wang <[email protected]>
+L: [email protected]

Need to make sure igvt-g-dev is open to non-subscribers first. Otherwise ack.

Quoted 8 lines
	+L:      [email protected]
	+W:      https://01.org/igvt-g
	+T:      git https://github.com/01org/gvt-linux.git
	+S:      Supported
	+F:      drivers/gpu/drm/i915/gvt/

I think we'll want to keep intel-gfx there, but mostly I think it's fine for the usual GVT-g development to happen on igvt-g-dev only.

+1

Quoted 4 lines

* [email protected] needs to start accepting mails from non-subscribers.

=> Work in progress.

Definitely ;-)

Quoted 6 lines

* GVT-g needs to start paying more attention to compiler and sparse warnings.

=> GVT-G maintainers will take care of this.

* GVT-g could use some overview documentation under Documentation/gpu.

Hm, should we have a TODO file in gvt for some of the issues raised? Otoh most things are fairly small issues, so should all be fixable before 4.10 freeze.

Quoted 3 lines

* GVT-g bug management. Do you have something set up already? Would be great to be able to use https://bugs.freedesktop.org so we could reassign between i915 and GVT-g.

+1.

Quoted 1 line

What did I forget/overlook?

Nothing else crosses my mind, but I'm sure we'll discover more ;-) -Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 14 lines · Daniel Vetter
Quoted 13 lines · Jani Nikula

We need to formalize the process between i915 proper and GVT-g a bit more, and address some of the current shortcomings and issues in the process and GVT-g CI.

This started off internally as a random list of items, I'm including some of the current status as well. Please comment, as some of the stuff here are just my opinions.

* How do we ensure GVT-g patches get the same kind of pre-merge CI coverage as we have for other i915 code? Could we at least make CI run tests on GVT-g pull requests before merging to drm-intel trees?

Quoted 6 lines
Quoted 1 line

=> Work in progress to set up GVT-g CI.

Personally I don't think gvt needs to pass drm-intel CI. If GVT folks want to do that then it's fine, but otherwise I'm leaning towards treating gvt like a sub-driver, with its own flavour of testing and review standards.

Normally GVT-g shouldn't impact drm-intel CI. I do like to setup GVT-g specific CI with fancy multiple VMs auto test available. But it might need some time for QA team to setup that way.

Quoted 10 lines

Of course anything touching shared code (i.e. outside of the gvt/ subdir), or code which can't be disabled with Kconfig needs to follow our established review&testing procedures. So submission to intel-gfx, CI by patchwork, review per our standards.

Quoted 5 lines

* How do we handle fixes to GVT-g code? Do all fixes need to go via the GVT-g mailing lists and review? We're bound to get GVT-g patches on intel-gfx mailing list too. There's confusion already [1]. Mostly the GVT-g changes come from GVT-g maintainers as pull requests.

Quoted 6 lines
Quoted 1 line

[1] https://patchwork.freedesktop.org/series/14000/

Atm the gvt mailing list is closed, and there's no maintainer entry for it either. I think Zhenyu just needs to hang out here on intel-gfx to catch these, and then pick any gvt/ fixes up himself.

We're working with 01.org admin to fix that ASAP. I didn't realize 01.org list has such issue, just thought we have aligned user/dev igvt-g list on same place, otherwise I'd have considered other way.. But yes, we will still include intel-gfx list in maintainer file and keep eye on it.

Quoted 5 lines
Quoted 3 lines

* GVT-g related changes to i915 proper must be reviewed on intel-gfx mailing list, and must either be applied to drm-intel directly, or get an ack to be merged via GVT-g tree and pull requests.

Ack.

Agreed.

Quoted 11 lines
Quoted 6 lines

* GVT-g needs to start annotating fixes with the Fixes: tags, preferably also cc: stable when we get that far, so our fixes plumbing can figure out which commits to backport.

=> GVT-g maintainers will take care of this.

Either that, or they need to send -fixes pull requests your way. I think we could try out either approach, but yes in the end gvt maintainers need to own this. We (i915 team here) won't take care of that.

yeah, I think we should follow that way.

Quoted 11 lines
Quoted 8 lines

* Should GVT-g have a MAINTAINERS entry of its own?

=> https://github.com/01org/gvt-linux/commit/41161c9e9e50a5bad98a0e74ad0878c352bdea40

+INTEL GVT-g DRIVERS (Intel GPU Virtualization)
+M: Zhenyu Wang <[email protected]>
+M: Zhi Wang <[email protected]>
+L: [email protected]

Need to make sure igvt-g-dev is open to non-subscribers first. Otherwise ack.

fixing...

Quoted 22 lines
Quoted 9 lines
	+L:      [email protected]
	+W:      https://01.org/igvt-g
	+T:      git https://github.com/01org/gvt-linux.git
	+S:      Supported
	+F:      drivers/gpu/drm/i915/gvt/

I think we'll want to keep intel-gfx there, but mostly I think it's fine for the usual GVT-g development to happen on igvt-g-dev only.

+1

Quoted 4 lines

* [email protected] needs to start accepting mails from non-subscribers.

=> Work in progress.

Definitely ;-)

Quoted 3 lines

* GVT-g needs to start paying more attention to compiler and sparse warnings.

Quoted 7 lines
Quoted 3 lines

=> GVT-G maintainers will take care of this.

* GVT-g could use some overview documentation under Documentation/gpu.

Hm, should we have a TODO file in gvt for some of the issues raised? Otoh most things are fairly small issues, so should all be fixable before 4.10 freeze.

Next big merge will be integration work with VFIO/mdev framework. Both VFIO/mdev and our GVT-g device model work are for 4.10. Currently we already have working patch sets internally based on newest VFIO/mdev v9 series. We'd like to put a topic branch this week to be reviewed by VFIO community to make sure everything work as designed.

I think a TODO file might help us to track left issues, will consider that.

Quoted 6 lines
Quoted 4 lines

* GVT-g bug management. Do you have something set up already? Would be great to be able to use https://bugs.freedesktop.org so we could reassign between i915 and GVT-g.

+1.

yeah, that's also in our plan, will create new category for GVT-g driver. Our QA team will handle that.

Quoted 4 lines
Quoted 2 lines

What did I forget/overlook?

Nothing else crosses my mind, but I'm sure we'll discover more ;-)

Thanks to summarize this! Really help to clarify for other people.

Signature · 3 lines
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 17 lines · Zhenyu Wang
Quoted 16 lines · Daniel Vetter
Quoted 14 lines · Jani Nikula

We need to formalize the process between i915 proper and GVT-g a bit more, and address some of the current shortcomings and issues in the process and GVT-g CI.

This started off internally as a random list of items, I'm including some of the current status as well. Please comment, as some of the stuff here are just my opinions.

* How do we ensure GVT-g patches get the same kind of pre-merge CI coverage as we have for other i915 code? Could we at least make CI run tests on GVT-g pull requests before merging to drm-intel trees?

=> Work in progress to set up GVT-g CI.

Quoted 8 lines
Quoted 4 lines

Personally I don't think gvt needs to pass drm-intel CI. If GVT folks want to do that then it's fine, but otherwise I'm leaning towards treating gvt like a sub-driver, with its own flavour of testing and review standards.

Normally GVT-g shouldn't impact drm-intel CI. I do like to setup GVT-g specific CI with fancy multiple VMs auto test available. But it might need some time for QA team to setup that way.

The problem is that gvt is a consumer of our APIs. When I change those I need reassurance that gvt does not break. We also need reassurance that when we backmerge from upstream changes to the hva do not break gvt. -Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw
Quoted 23 lines · Chris Wilson
Quoted 22 lines · Zhenyu Wang
Quoted 20 lines · Daniel Vetter
Quoted 9 lines · Jani Nikula

We need to formalize the process between i915 proper and GVT-g a bit more, and address some of the current shortcomings and issues in the process and GVT-g CI.

This started off internally as a random list of items, I'm including some of the current status as well. Please comment, as some of the stuff here are just my opinions.

Quoted 5 lines

* How do we ensure GVT-g patches get the same kind of pre-merge CI coverage as we have for other i915 code? Could we at least make CI run tests on GVT-g pull requests before merging to drm-intel trees?

=> Work in progress to set up GVT-g CI.

Personally I don't think gvt needs to pass drm-intel CI. If GVT folks want to do that then it's fine, but otherwise I'm leaning towards treating gvt like a sub-driver, with its own flavour of testing and review standards.

Quoted 7 lines
Quoted 3 lines

Normally GVT-g shouldn't impact drm-intel CI. I do like to setup GVT-g specific CI with fancy multiple VMs auto test available. But it might need some time for QA team to setup that way.

The problem is that gvt is a consumer of our APIs. When I change those I need reassurance that gvt does not break. We also need reassurance that when we backmerge from upstream changes to the hva do not break gvt.

yeah, I think that's also a requirement for GVT-g CI. Another side is similiar nightly branch for gvt will be created to grab drm-intel, gvt, vfio, kvm and future xen trees to do regression testing and with more full testings. I hope some part of GVT-g CI could also be put in drm-intel CI and other part is for GVT-g testing itself e.g VM related features, etc.

Signature · 3 lines
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
In reply to Zhenyu Wang
Quoted 10 lines · Zhenyu Wang
Quoted 6 lines · Daniel Vetter
Quoted 3 lines · Jani Nikula

* GVT-g bug management. Do you have something set up already? Would be great to be able to use https://bugs.freedesktop.org so we could reassign between i915 and GVT-g.

+1.

yeah, that's also in our plan, will create new category for GVT-g driver. Our QA team will handle that.

Please connect them with Martin Peres (CC'd) who'll be able to get this done.

BR,
Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx