Skip to contentSkip to conversation

qmake5_paths.bbclass: Fix fonts installation path

PATCH In review Otavio Salvador 3 participants 5 messages Oct 20, 2016 – Oct 24, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qmake5_paths.bbclass: Fix fonts installation path

As Qt internal fonts (qtbase-fonts) are not included anymore, we need to rely on system fonts to work.

All major distributions, as well as all recipes on OE-Core and Meta-OE, use ${datadir}/fonts as path so we adapt the value for use for Qt use as well.

---

 classes/qmake5_paths.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
classes/qmake5_paths.bbclass +1 -1
index e1101a9..ef3ff8f 100644
@@ -49,4 +49,4 @@ OE_QMAKE_PATH_QT_SETTINGS = "${sysconfdir}${QT_DIR_NAME}"
 OE_QMAKE_PATH_QT_EXAMPLES = "${datadir}${QT_DIR_NAME}/examples"
 OE_QMAKE_PATH_QT_TESTS = "${datadir}${QT_DIR_NAME}/tests"
 
-OE_QMAKE_PATH_QT_FONTS = "${OE_QMAKE_PATH_LIBS}/fonts"
+OE_QMAKE_PATH_QT_FONTS = "${OE_QMAKE_PATH_DATA}/fonts"
Signature · 1 line
2.10.0
#1 lore raw

Hello folks,

Quoted 8 lines · Otavio Salvador

As Qt internal fonts (qtbase-fonts) are not included anymore, we need to rely on system fonts to work.

All major distributions, as well as all recipes on OE-Core and Meta-OE, use ${datadir}/fonts as path so we adapt the value for use for Qt use as well.

Please take a look at this. This fixes a customer which were trying to use morty with Qt Virtual Keyboard.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#2 lore raw

That looks like the correct path to use, but how does this fix the problem?
OE_QMAKE_PATH_QT_FONTS doesn't seem to used anywhere in meta-qt5 any more and probably should have been removed together with the font packaging bits.

-samuli

Quoted 16 lines · Otavio Salvador

Hello folks,

Quoted 8 lines · Otavio Salvador

As Qt internal fonts (qtbase-fonts) are not included anymore, we need to rely on system fonts to work.

All major distributions, as well as all recipes on OE-Core and Meta-OE, use ${datadir}/fonts as path so we adapt the value for use for Qt use as well.

Please take a look at this. This fixes a customer which were trying to use morty with Qt Virtual Keyboard.

#3 lore raw
Quoted 3 lines · Samuli Piippo

That looks like the correct path to use, but how does this fix the problem? OE_QMAKE_PATH_QT_FONTS doesn't seem to used anywhere in meta-qt5 any more and probably should have been removed together with the font packaging bits.

It did not fix it, indeed. We had a left over from a test so it hided the issue. We are checking it now.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#4 lore raw
Quoted 7 lines · Otavio Salvador
Quoted 3 lines · Samuli Piippo

That looks like the correct path to use, but how does this fix the problem? OE_QMAKE_PATH_QT_FONTS doesn't seem to used anywhere in meta-qt5 any more and probably should have been removed together with the font packaging bits.

It did not fix it, indeed. We had a left over from a test so it hided the issue. We are checking it now.

This change ought to be ignored; the Qt QPA has a hardcoded path which can be overridden using an environment var and this seems to be the standard practice for people not using fontconfig support.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750