drm/i915: Give write permission to gt_boost_freq_mhz
Subsystems (2)
PATCH 1/1 drm/i915: Give write permission to gt_boost_freq_mhz
--- drivers/gpu/drm/i915/i915_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_sysfs.c +1 -1
@@ -460,7 +460,7 @@ static ssize_t gt_min_freq_mhz_store(struct device *kdev, static DEVICE_ATTR(gt_act_freq_mhz, S_IRUGO, gt_act_freq_mhz_show, NULL); static DEVICE_ATTR(gt_cur_freq_mhz, S_IRUGO, gt_cur_freq_mhz_show, NULL); -static DEVICE_ATTR(gt_boost_freq_mhz, S_IRUGO, gt_boost_freq_mhz_show, gt_boost_freq_mhz_store); +static DEVICE_ATTR(gt_boost_freq_mhz, S_IRUGO | S_IWUSR, gt_boost_freq_mhz_show, gt_boost_freq_mhz_store); static DEVICE_ATTR(gt_max_freq_mhz, S_IRUGO | S_IWUSR, gt_max_freq_mhz_show, gt_max_freq_mhz_store); static DEVICE_ATTR(gt_min_freq_mhz, S_IRUGO | S_IWUSR, gt_min_freq_mhz_show, gt_min_freq_mhz_store);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915: Give write permission to gt_boost_freq_mhz
== Series Details ==
== Series Details ==
Series: series starting with [1/1] drm/i915: Give write permission to gt_boost_freq_mhz
URL : https://patchwork.freedesktop.org/series/14228/
State : success
== Summary ==
Series 14228v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/14228/revisions/1/mbox/
fi-bdw-5557u total:246 pass:231 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:246 pass:204 dwarn:0 dfail:0 fail:0 skip:42 fi-bxt-t5700 total:246 pass:216 dwarn:0 dfail:0 fail:0 skip:30 fi-byt-j1900 total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31 fi-byt-n2820 total:246 pass:211 dwarn:0 dfail:0 fail:0 skip:35 fi-hsw-4770 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22 fi-hsw-4770r total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22 fi-ilk-650 total:246 pass:185 dwarn:0 dfail:0 fail:1 skip:60 fi-ivb-3520m total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25 fi-kbl-7200u total:246 pass:222 dwarn:0 dfail:0 fail:0 skip:24 fi-skl-6260u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:246 pass:219 dwarn:4 dfail:0 fail:0 skip:23 fi-skl-6700k total:246 pass:222 dwarn:1 dfail:0 fail:0 skip:23 fi-skl-6770hq total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14 fi-snb-2520m total:246 pass:210 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:246 pass:209 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2796/
b04b19cd9268a3ce2d406fbe42d4cfac9f962871 drm-intel-nightly: 2016y-10m-22d-08h-48m-58s UTC integration manifest f0526a6 drm/i915: Give write permission to gt_boost_freq_mhz
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote:
And uabi change with 0 commit message. This needs to be _much_ better ;-) -Daniel
Quoted 26 lines
Cc Chris Wilson <[email protected]>Signed-off-by Sagar Arun Kamble <[email protected]>--- drivers/gpu/drm/i915/i915_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/i915_sysfs.c +1
-1@@ -460,7 +460,7 @@ static ssize_t gt_min_freq_mhz_store(struct device *kdev, static DEVICE_ATTR(gt_act_freq_mhz, S_IRUGO, gt_act_freq_mhz_show, NULL); static DEVICE_ATTR(gt_cur_freq_mhz, S_IRUGO, gt_cur_freq_mhz_show, NULL); -static DEVICE_ATTR(gt_boost_freq_mhz, S_IRUGO, gt_boost_freq_mhz_show, gt_boost_freq_mhz_store); +static DEVICE_ATTR(gt_boost_freq_mhz, S_IRUGO | S_IWUSR, gt_boost_freq_mhz_show, gt_boost_freq_mhz_store); static DEVICE_ATTR(gt_max_freq_mhz, S_IRUGO | S_IWUSR, gt_max_freq_mhz_show, gt_max_freq_mhz_store); static DEVICE_ATTR(gt_min_freq_mhz, S_IRUGO | S_IWUSR, gt_min_freq_mhz_show, gt_min_freq_mhz_store);Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Daniel Vetter
On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote:
And uabi change with 0 commit message. This needs to be _much_ better ;-)
Also the patch subject isn't really useful: It's a literal translation from the patch to Enlish, which adds nothing. Much better to summarize a patch in terms of impacts and goals, e.g. "Allow userspace to set gpu boost".
Plus of course then explain in the commit message why that is a good idea, why we need it, testcase and userspace for this and all this stuff. -Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Daniel Vetter
On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote:
And uabi change with 0 commit message. This needs to be _much_ better ;-)
A case where the author cut'n'paste the wrong thing because he can't read S_INCOMPREHENSIBLELINENOISE as opposed to the traditional 0600. -Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Daniel, Chris,
Sorry for not clarifying the purpose and if any misunderstanding. This was to allow running at fixed frequency.
Kindly clarify if it is intentional to have _store routine without S_IWUSR.
Quoted 8 lines · Chris Wilson
Quoted 3 lines · Daniel Vetter
On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote:
And uabi change with 0 commit message. This needs to be _much_ better ;-)
A case where the author cut'n'paste the wrong thing because he can't read
S_INCOMPREHENSIBLELINENOISEas opposed to the traditional 0600. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 15 lines · Sagar A
Hi Daniel, Chris,
Sorry for not clarifying the purpose and if any misunderstanding. This was to allow running at fixed frequency.
Kindly clarify if it is intentional to have
_storeroutine withoutS_IWUSR.Quoted 6 lines · Chris Wilson
Quoted 3 lines · Daniel Vetter
On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote:
And uabi change with 0 commit message. This needs to be _much_ better ;-)
A case where the author cut'n'paste the wrong thing because he can't read
S_INCOMPREHENSIBLELINENOISEas opposed to the traditional 0600.
Oh, if it's a bugfix, then it should come with a Fixes: line, preferrably generated using dim fixes.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx