Skip to contentSkip to conversation

mmc: add the device name in debugging message for supplying vmmc

PATCH New Jaehoon Chung 2 participants 3 messages Oct 24, 2016 – Oct 26, 2016 MMC, SD and SDIO

lore
Share & tools
lore

Jaehoon Chung

author
#0 lore raw

PATCH 1/1 mmc: add the device name in debugging message for supplying vmmc

If vmmc didn't supply, we didn't know which card didn't supply vmmc. And changed from "put" to "debug".

Signed-off-by Jaehoon Chung <[email protected]>
---
 drivers/mmc/mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/mmc.c +1 -1
index 320413a..4380c7c 100644
@@ -1595,7 +1595,7 @@ static int mmc_power_init(struct mmc *mmc)
 	ret = device_get_supply_regulator(mmc->dev, "vmmc-supply",
 					  &vmmc_supply);
 	if (ret) {
-		puts("No vmmc supply\n");
+		debug("%s: No vmmc supply\n", mmc->dev->name);
 		return 0;
 	}
Signature · 1 line
2.10.1
#1 lore raw

PATCH 1/1 mmc: add the device name in debugging message for supplying vmmc

Hi Chung,

Quoted 4 lines · Jaehoon Chung

If vmmc didn't supply, we didn't know which card didn't supply vmmc. And changed from "put" to "debug".

Signed-off-by Jaehoon Chung <[email protected]>
Reviewed-by Peng Fan <[email protected]>

Regards,
Peng.

Quoted 24 lines

---
drivers/mmc/mmc.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/mmc.c +1 -1
index 320413a..4380c7c 100644
@@ -1595,7 +1595,7 @@ static int mmc_power_init(struct mmc *mmc)
 	ret = device_get_supply_regulator(mmc->dev, "vmmc-supply",
 					  &vmmc_supply);
 	if (ret) {
-		puts("No vmmc supply\n");
+		debug("%s: No vmmc supply\n", mmc->dev->name);
 		return 0;
 	}
Signature · 6 lines
2.10.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
author
#2 lore raw

PATCH 1/1 mmc: add the device name in debugging message for supplying vmmc

Quoted 8 lines · Peng Fan

Hi Chung,

Quoted 4 lines · Jaehoon Chung

If vmmc didn't supply, we didn't know which card didn't supply vmmc. And changed from "put" to "debug".

Signed-off-by Jaehoon Chung <[email protected]>
Reviewed-by Peng Fan <[email protected]>

Applied on u-boot-mmc. Thanks.

Best Regards,
Jaehoon Chung

Quoted 31 lines

Regards,
Peng.

Quoted 24 lines

---
drivers/mmc/mmc.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/mmc.c +1 -1
index 320413a..4380c7c 100644
@@ -1595,7 +1595,7 @@ static int mmc_power_init(struct mmc *mmc)
 	ret = device_get_supply_regulator(mmc->dev, "vmmc-supply",
 					  &vmmc_supply);
 	if (ret) {
-		puts("No vmmc supply\n");
+		debug("%s: No vmmc supply\n", mmc->dev->name);
 		return 0;
 	}
Signature · 6 lines
2.10.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot