Skip to contentSkip to conversation

ARM: imx: mach-imx6q: Fix the PHY ID mask for AR8031

PATCH New Fabio Estevam 2 participants 3 messages Oct 24, 2016

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: imx: mach-imx6q: Fix the PHY ID mask for AR8031

From: Fabio Estevam <[email protected]>

AR8031 and AR8035 have the same PHY ID mask of 0xffffffef.

So fix it and make it match with the PHY ID mask definition at drivers/net/phy/at803x.c.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/mach-imx/mach-imx6q.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/mach-imx6q.c +1 -1
index 97fd251..45801b2 100644
@@ -173,7 +173,7 @@ static void __init imx6q_enet_phy_init(void)
 				ksz9021rn_phy_fixup);
 		phy_register_fixup_for_uid(PHY_ID_KSZ9031, MICREL_PHY_ID_MASK,
 				ksz9031rn_phy_fixup);
-		phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffff,
+		phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffef,
 				ar8031_phy_fixup);
 		phy_register_fixup_for_uid(PHY_ID_AR8035, 0xffffffef,
 				ar8035_phy_fixup);
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 ARM: imx: mach-imx6q: Fix the PHY ID mask for AR8031

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

AR8031 and AR8035 have the same PHY ID mask of 0xffffffef.

So fix it and make it match with the PHY ID mask definition at drivers/net/phy/at803x.c.

It was working well with a wrong ID?

Shawn

Quoted 26 lines
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/mach-imx/mach-imx6q.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/mach-imx6q.c +1 -1
index 97fd251..45801b2 100644
@@ -173,7 +173,7 @@ static void __init imx6q_enet_phy_init(void)
 				ksz9021rn_phy_fixup);
 		phy_register_fixup_for_uid(PHY_ID_KSZ9031, MICREL_PHY_ID_MASK,
 				ksz9031rn_phy_fixup);
-		phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffff,
+		phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffef,
 				ar8031_phy_fixup);
 		phy_register_fixup_for_uid(PHY_ID_AR8035, 0xffffffef,
 				ar8035_phy_fixup);
Signature · 7 lines
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author reviewer
#2 lore raw

PATCH 1/1 ARM: imx: mach-imx6q: Fix the PHY ID mask for AR8031

Quoted 9 lines · Shawn Guo
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

AR8031 and AR8035 have the same PHY ID mask of 0xffffffef.

So fix it and make it match with the PHY ID mask definition at drivers/net/phy/at803x.c.

It was working well with a wrong ID?

Yes, it was working well even with the wrong PHY ID mask.