Skip to contentSkip to conversation

drm/panel: simple: Check against num_timings when setting preferred for timing

PATCH Applied Chen-Yu Tsai 2 participants 2 messages Oct 24, 2016 – Dec 6, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel: simple: Check against num_timings when setting preferred for timing

In the loop on .timings, we should check .num_timings to see if it's the only mode specified, not .num_modes, which should be used with .modes.

Fixes cda553725c92 ("drm/panel: simple: Set appropriate mode type")
---
 drivers/gpu/drm/panel/panel-simple.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/panel/panel-simple.c +1 -1
index 113db3c4a633..27cb42467b20 100644
@@ -120,7 +120,7 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel)
 
 		mode->type |= DRM_MODE_TYPE_DRIVER;
 
-		if (panel->desc->num_modes == 1)
+		if (panel->desc->num_timings == 1)
 			mode->type |= DRM_MODE_TYPE_PREFERRED;
 
 		drm_mode_probed_add(connector, mode);
Signature · 1 line
2.9.3
#1 lore raw
Quoted 8 lines · Chen-Yu Tsai

In the loop on .timings, we should check .num_timings to see if it's the only mode specified, not .num_modes, which should be used with .modes.

Fixes cda553725c92 ("drm/panel: simple: Set appropriate mode type")
---
 drivers/gpu/drm/panel/panel-simple.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thierry

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel