present: Check tiling info for flips
PATCH 1/1 present: Check tiling info for flips
From: Michel Dänzer <[email protected]>
The kernel driver doesn't handle flipping between buffers with different tiling parameters correctly.
Fixes display corruption with fullscreen apps using different tiling modes (e.g. due to R600_DEBUG=notiling or R600_DEBUG=no2d) via DRI3.
--- src/amdgpu_present.c | 7 +++++++ 1 file changed, 7 insertions(+)
src/amdgpu_present.c +7 -0
@@ -262,6 +262,13 @@ amdgpu_present_check_flip(RRCrtcPtr crtc, WindowPtr window, PixmapPtr pixmap,if (info->drmmode.dri2_flipping)return FALSE; +/* The kernel driver doesn't handle flipping between BOs with different +* tiling parameters correctly yet +*/ +if (amdgpu_pixmap_get_tiling_info (pixmap) != +amdgpu_pixmap_get_tiling_info (screen->GetScreenPixmap (screen))) +return FALSE; +return amdgpu_present_check_unflip (scrn); }
Signature · 6 lines
2.10.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20161027022609.3583-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org
Alex Deucher
Reviewed-byQuoted 9 lines · Michel Dänzer
From: Michel Dänzer <[email protected]>
The kernel driver doesn't handle flipping between buffers with different tiling parameters correctly.
Fixes display corruption with fullscreen apps using different tiling modes (e.g. due to R600_DEBUG=notiling or R600_DEBUG=no2d) via DRI3.
Signed-off-by Michel Dänzer <[email protected]>
Quoted 25 lines
--- src/amdgpu_present.c | 7 +++++++ 1 file changed, 7 insertions(+)src/amdgpu_present.c +7
-1@@ -262,6 +262,13 @@ amdgpu_present_check_flip(RRCrtcPtr crtc, WindowPtr window, PixmapPtr pixmap,if (info->drmmode.dri2_flipping)return FALSE; +/* The kernel driver doesn't handle flipping between BOs with different +* tiling parameters correctly yet +*/ +if (amdgpu_pixmap_get_tiling_info (pixmap) != +amdgpu_pixmap_get_tiling_info (screen->GetScreenPixmap (screen))) +return FALSE; +return amdgpu_present_check_unflip (scrn); } --2.10.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx