Skip to contentSkip to conversation

binutils: add comment with bug report reference

PATCH New Waldemar Brodkorb 2 participants 5 messages Oct 30, 2016 – Nov 1, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 binutils: add comment with bug report reference

Add requested bug report

---
 package/binutils/Config.in.host | 1 +
 1 file changed, 1 insertion(+)
package/binutils/Config.in.host +1 -0
index a7610b4..dce6996 100644
@@ -18,6 +18,7 @@ choice
 	config BR2_BINUTILS_VERSION_2_27_X
 		bool "binutils 2.27"
 		# supported but broken on Microblaze
+		# see https://sourceware.org/bugzilla/show_bug.cgi?id=20748
 		depends on !BR2_microblaze
 
 endchoice
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 binutils: add comment with bug report reference

Hello,

Quoted 12 lines · Waldemar Brodkorb

Add requested bug report

---
 package/binutils/Config.in.host | 1 +
 1 file changed, 1 insertion(+)
package/binutils/Config.in.host +0 -0
index a7610b4..dce6996 100644

package/binutils/Config.in.host choice · line 22

Quoted 5 lines
package/binutils/Config.in.host +1 -0
@@ -18,6 +18,7 @@ choice
 	config BR2_BINUTILS_VERSION_2_27_X
 		bool "binutils 2.27"
 		# supported but broken on Microblaze
+		# see https://sourceware.org/bugzilla/show_bug.cgi?id=20748
 		depends on !BR2_microblaze

Your bug report is about binutils 2.27 generating broken binaries for microblaze/musl, but you disable binutils 2.27 completely for microblaze, and not just for musl. Why so?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 binutils: add comment with bug report reference

Hi Thomas,
Thomas Petazzoni wrote,

Quoted 10 lines

Hello,

Quoted 7 lines · Waldemar Brodkorb

Add requested bug report

---
 package/binutils/Config.in.host | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

package/binutils/Config.in.host choice · line 22

Quoted 10 lines
package/binutils/Config.in.host +1 -0
index a7610b4..dce6996 100644
@@ -18,6 +18,7 @@ choice
 	config BR2_BINUTILS_VERSION_2_27_X
 		bool "binutils 2.27"
 		# supported but broken on Microblaze
+		# see https://sourceware.org/bugzilla/show_bug.cgi?id=20748
 		depends on !BR2_microblaze

Your bug report is about binutils 2.27 generating broken binaries for microblaze/musl, but you disable binutils 2.27 completely for microblaze, and not just for musl. Why so?

Because the binutils bug affects musl/uClibc-ng and glibc. I just used musl to bisect and simplified the bug report. Furthermore I normally get very good support from the musl devs in case of toolchain issues.

best regards
Waldemar

#3 lore raw

PATCH 1/1 binutils: add comment with bug report reference

Hello,

Quoted 10 lines · Waldemar Brodkorb
Quoted 9 lines

package/binutils/Config.in.host choice · line 22

Quoted 5 lines
package/binutils/Config.in.host +1 -0
 	config BR2_BINUTILS_VERSION_2_27_X
 		bool "binutils 2.27"
 		# supported but broken on Microblaze
+		# see https://sourceware.org/bugzilla/show_bug.cgi?id=20748
 		depends on !BR2_microblaze  

Your bug report is about binutils 2.27 generating broken binaries for microblaze/musl, but you disable binutils 2.27 completely for microblaze, and not just for musl. Why so?

Quoted 4 lines

Because the binutils bug affects musl/uClibc-ng and glibc. I just used musl to bisect and simplified the bug report. Furthermore I normally get very good support from the musl devs in case of toolchain issues.

ACK, thanks for the explanation. But then perhaps your bug report should be made more accurate? As it is written, one might understand than it is a musl-specific problem. Knowing that uclibc-ng and glibc are also affected is quite important IMO.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 binutils: add comment with bug report reference

In reply to Waldemar Brodkorb

Hello,

Quoted 6 lines · Waldemar Brodkorb

Add requested bug report

---
 package/binutils/Config.in.host | 1 +
 1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com