Skip to contentSkip to conversation

package/libfribidi: remove optional dependency to libglib

PATCH New Bernd Kuhls 3 participants 3 messages Oct 30, 2016 – Nov 1, 2016

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH v3 1/1 package/libfribidi: remove optional dependency to libglib

Fixes vdr compile error:
http://autobuild.buildroot.net/results/725/7252decffe29e19051eed0554786651aee216573/

Instead of fixing fribidi.pc or adding optional CFLAGS to the vdr package we remove the optional libglib dependency because it does not contain "any thing substantial" as pointed out in an pull request sent
upstream: https://github.com/behdad/fribidi/pull/14

Signed-off-by Bernd Kuhls <[email protected]>

---
v3: instead of patching libfribidi we force glib=no (Thomas)
v2: added patch 0003 to fix fribidi.pc

 package/libfribidi/libfribidi.mk | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
package/libfribidi/libfribidi.mk +4 -6
index 4e82a5e..86e722a 100644
@@ -14,11 +14,9 @@ LIBFRIBIDI_INSTALL_STAGING = YES
 # Run autoreconf to regenerate ltmain.sh.
 LIBFRIBIDI_AUTORECONF = YES
 LIBFRIBIDI_DEPENDENCIES = host-pkgconf
-
-ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
-LIBFRIBIDI_DEPENDENCIES += libglib2
-else
-LIBFRIBIDI_CONF_OPTS += --with-glib=no
-endif
+# libglib2 dependency causes a build failure, and this optional
+# dependency is going to be removed usptream, see
+# https://github.com/behdad/fribidi/pull/14
+LIBFRIBIDI_CONF_OPTS = --with-glib=no
 
 $(eval $(autotools-package))
Signature · 1 line
2.10.1
#1 lore raw

PATCH v3 1/1 package/libfribidi: remove optional dependency to libglib

Bernd, All,

On 2016-10-30 18:29 +0100, Bernd Kuhls spake thusly:

Quoted 9 lines

Fixes vdr compile error:
http://autobuild.buildroot.net/results/725/7252decffe29e19051eed0554786651aee216573/

Instead of fixing fribidi.pc or adding optional CFLAGS to the vdr package we remove the optional libglib dependency because it does not contain "any thing substantial" as pointed out in an pull request sent
upstream: https://github.com/behdad/fribidi/pull/14

Signed-off-by Bernd Kuhls <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 34 lines

---
v3: instead of patching libfribidi we force glib=no (Thomas)
v2: added patch 0003 to fix fribidi.pc

 package/libfribidi/libfribidi.mk | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
package/libfribidi/libfribidi.mk +4 -6
index 4e82a5e..86e722a 100644
@@ -14,11 +14,9 @@ LIBFRIBIDI_INSTALL_STAGING = YES
 # Run autoreconf to regenerate ltmain.sh.
 LIBFRIBIDI_AUTORECONF = YES
 LIBFRIBIDI_DEPENDENCIES = host-pkgconf
-
-ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
-LIBFRIBIDI_DEPENDENCIES += libglib2
-else
-LIBFRIBIDI_CONF_OPTS += --with-glib=no
-endif
+# libglib2 dependency causes a build failure, and this optional
+# dependency is going to be removed usptream, see
+# https://github.com/behdad/fribidi/pull/14
+LIBFRIBIDI_CONF_OPTS = --with-glib=no
 
 $(eval $(autotools-package))
Signature · 6 lines
2.10.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH v3 1/1 package/libfribidi: remove optional dependency to libglib

In reply to Bernd Kuhls

Hello,

Quoted 8 lines · Bernd Kuhls

Fixes vdr compile error:
http://autobuild.buildroot.net/results/725/7252decffe29e19051eed0554786651aee216573/

Instead of fixing fribidi.pc or adding optional CFLAGS to the vdr package we remove the optional libglib dependency because it does not contain "any thing substantial" as pointed out in an pull request sent
upstream: https://github.com/behdad/fribidi/pull/14

Quoted 4 lines
Signed-off-by Bernd Kuhls <[email protected]>

---
v3: instead of patching libfribidi we force glib=no (Thomas)
v2: added patch 0003 to fix fribidi.pc

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com