Skip to contentSkip to conversation

mfd: sun4i-gpadc: select regmap-irq

PATCH Applied Arnd Bergmann 2 participants 2 messages Oct 31, 2016 – Nov 14, 2016 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: sun4i-gpadc: select regmap-irq

The new sun4i mfd driver is lacking a dependency, triggering very rarely int randconfig kernel builds:

drivers/mfd/sun4i-gpadc.o: In function `sun4i_gpadc_probe':
sun4i-gpadc.c:(.text.sun4i_gpadc_probe+0x110): undefined reference to `devm_regmap_add_irq_chip'

This adds a 'select REGMAP_IRQ', as the other drivers with this problem do.

---
 drivers/mfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/mfd/Kconfig +1 -0
index 30978295a1e8..3a4c43df9404 100644
@@ -44,6 +44,7 @@ config MFD_SUN4I_GPADC
 	tristate "Allwinner sunxi platforms' GPADC MFD driver"
 	select MFD_CORE
 	select REGMAP_MMIO
+	select REGMAP_IRQ
 	depends on ARCH_SUNXI || COMPILE_TEST
 	help
 	  Select this to get support for Allwinner SoCs (A10, A13 and A31) ADC.
Signature · 1 line
2.9.0
Applied
#1 lore raw
Quoted 6 lines · Arnd Bergmann

The new sun4i mfd driver is lacking a dependency, triggering very rarely int randconfig kernel builds:

drivers/mfd/sun4i-gpadc.o: In function `sun4i_gpadc_probe':
sun4i-gpadc.c:(.text.sun4i_gpadc_probe+0x110): undefined reference to `devm_regmap_add_irq_chip'

Quoted 6 lines

This adds a 'select REGMAP_IRQ', as the other drivers with this problem do.

---
 drivers/mfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks.

Quoted 12 lines
drivers/mfd/Kconfig +1 -0
index 30978295a1e8..3a4c43df9404 100644
@@ -44,6 +44,7 @@ config MFD_SUN4I_GPADC
 	tristate "Allwinner sunxi platforms' GPADC MFD driver"
 	select MFD_CORE
 	select REGMAP_MMIO
+	select REGMAP_IRQ
 	depends on ARCH_SUNXI || COMPILE_TEST
 	help
 	  Select this to get support for Allwinner SoCs (A10, A13 and A31) ADC.
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog